-
Notifications
You must be signed in to change notification settings - Fork 2.7k
fix: improve workflow validation error logging and display #8594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
elijahr
wants to merge
4
commits into
invoke-ai:main
Choose a base branch
from
elijahr:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b8c76e1
Improve workflow validation error logging and display
elijahr 830f197
Delete invokeai/frontend/web/.tool-versions
elijahr dd14c64
Revert invokeai/frontend/web/src/features/nodes/util/workflow/migrati…
elijahr 78826cf
Merge branch 'main' of github.com:elijahr/InvokeAI
elijahr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import type { z } from 'zod'; | ||
|
||
interface ZodErrorLogOptions { | ||
context?: string; | ||
} | ||
|
||
/** | ||
* Logs Zod validation errors with a simple description and complete error data. | ||
*/ | ||
export const logZodError = (error: z.ZodError, options: ZodErrorLogOptions = {}): void => { | ||
const { context = 'Validation' } = options; | ||
|
||
// eslint-disable-next-line no-console | ||
console.error(`${context} failed with ${error.issues.length} errors:`, { | ||
summary: error.issues.map((issue) => `${issue.path.join('.') || 'root'}: ${issue.message}`), | ||
issues: error.issues, | ||
}); | ||
}; | ||
|
||
/** | ||
* Creates a human-readable summary of Zod errors suitable for user-facing messages. | ||
* Limits the number of errors shown and provides a count of remaining errors. | ||
*/ | ||
export const createZodErrorSummary = ( | ||
error: z.ZodError, | ||
maxErrors: number = 10, | ||
pathFormatter?: (path: string, message: string) => string | ||
): string => { | ||
const defaultFormatter = (path: string, message: string) => `${path || 'Root'}: ${message}`; | ||
|
||
const formatter = pathFormatter || defaultFormatter; | ||
|
||
const errors = error.issues.map((issue) => formatter(issue.path.join('.'), issue.message)); | ||
|
||
const visibleErrors = errors.slice(0, maxErrors); | ||
const remainingCount = errors.length - maxErrors; | ||
|
||
let summary = visibleErrors.join('; '); | ||
|
||
if (remainingCount > 0) { | ||
summary += ` (+${remainingCount} more error${remainingCount === 1 ? '' : 's'})`; | ||
} | ||
|
||
return summary; | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets use the app logger here.