-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Feat(backend): Add improved download manager with pause/resume partial download. #8864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat(backend): Add improved download manager with pause/resume partial download. #8864
Conversation
|
@DustyShoe Does this handle the case where the user pauses and either:
|
|
@JPPhoto Ofc. you had to find worst case scenario...
|
|
@DustyShoe We can't predict what users or their systems will do, so coding defensively and being resilient (to a point) is always good. |
|
@JPPhoto Have to admit, that was a good point actually. Went back and added explicit toast message if temp file was removed and user tries to restart download. Also there was a bug in status bar updating. It did never reset to 0 in that case. |
Summary
This PR adds few cool things:
Parts of this code were written with assistance, so I’d appreciate any fixes or improvements.
QA Instructions
It might be better to run this with debug logging enabled.
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)