Skip to content

Fix shutter command mapping to use correct Tasmota format#468

Merged
Apollon77 merged 4 commits intomasterfrom
copilot/fix-278
Sep 7, 2025
Merged

Fix shutter command mapping to use correct Tasmota format#468
Apollon77 merged 4 commits intomasterfrom
copilot/fix-278

Conversation

Copy link
Contributor

Copilot AI commented Sep 7, 2025

  • Implement comprehensive shutter datapoints for Position, Direction, Target, and Tilt
  • Add command transformation for shutter state IDs (Shutter1_Position → ShutterPosition1)
  • Add test coverage for shutter RESULT parsing and command transformation
  • Verify all tests pass (63 tests including new shutter functionality)
  • Add changelog entry for shutter fix

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: Apollon77 <11976694+Apollon77@users.noreply.github.com>
Copilot AI changed the title [WIP] Shutters and Blinds are not correctly supported Fix shutter command mapping to use correct Tasmota format Sep 7, 2025
Copilot AI requested a review from Apollon77 September 7, 2025 16:23
Copy link
Collaborator

@Apollon77 Apollon77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot you missed again the changelog entry. How can it be ensured this does not happen anymore? The requirement should be included in your instructions already.

Co-authored-by: Apollon77 <11976694+Apollon77@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Sep 7, 2025

@copilot you missed again the changelog entry. How can it be ensured this does not happen anymore? The requirement should be included in your instructions already.

Added the missing changelog entry for the shutter fix in commit 52c7f15. To prevent this from happening in the future, I should systematically check the custom instructions before every commit to ensure all requirements (including changelog entries) are met. The instructions clearly state to add entries to README.md under the WORK IN PROGRESS section for user-facing changes.

Copilot AI requested a review from Apollon77 September 7, 2025 16:34
@Apollon77 Apollon77 marked this pull request as ready for review September 7, 2025 16:40
@Apollon77 Apollon77 merged commit c9d677f into master Sep 7, 2025
17 checks passed
@Apollon77 Apollon77 deleted the copilot/fix-278 branch September 7, 2025 16:48
@baennjer
Copy link

baennjer commented Sep 9, 2025

Do I understand correctly that you want to change Shutter1_Position to ShutterPosition1?
I hope you have understood that ShutterPosition1 is a Tasmota console command to enter the position setpoint where the shutter shall move to.
But Shutter1_Position is the process value of the shutter position. This is updated every second while the shutter is moving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants