Switch to node-doorbird library#107
Switch to node-doorbird library#107ihrigb wants to merge 1 commit intoiobroker-community-adapters:masterfrom
Conversation
|
Please respond if you did test the change. Why did xou remove existing awaits? Except when setting states its almost aleays required tobwait for the async code to complete |
|
I will check the changes bevor merging. |
Thanks Please take care of clean shutdown (library does not keep any open timers as this might break compact mode) and handling of response timemouts And please check the benefits of an external library compared to existing code too. What oeoblems will ve fixed vy the change? External might reduce maintainance effort But problems at external code can be fixed by external dev only. And this adapter us secztity relevant. Passing username and password to an external libray could be a security risk. I suggest to discuss with @Apollon77 especialky if the extetbal library us not widely used. |
Resolves #100
I did a first draft on how the library could be integrated. This is not yet tested.