Correct comments wrt CC in example Makefile#227
Merged
lcn2 merged 1 commit intoioccc-src:masterfrom Nov 18, 2025
Merged
Conversation
A long while back I improved the Makefiles to allow for compiler specific flags so that they don't have to be only "clang" or "gcc". This is because in some systems gcc is actually clang (macOS does this). Also if someone wants to use a different version or path then they can do so with the right flags enabled. Before that change it would not work right. The comments suggested these flags will only be set when CC is exactly "clang" or "gcc". This has been corrected.
Contributor
Author
|
Will reply to the issue about documentation later on .. I have some thoughts on the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long while back I improved the Makefiles to allow for compiler specific flags so that they don't have to be only "clang" or "gcc". This is because in some systems gcc is actually clang (macOS does this). Also if someone wants to use a different version or path then they can do so with the right flags enabled. Before that change it would not work right.
The comments suggested these flags will only be set when CC is exactly "clang" or "gcc". This has been corrected.