Use quotactl_fd syscall when available #180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in cms-dev/cms#1530, this is necessary to use tmpfs quotas.
I made it conditional on whether SYS_quotactl_fd is defined. This has been true since kernel 5.14 released around 4 years ago, your choice if you want to keep the old code to support older kernels.
(Also, it's possible that someone might be running a newer distro with an older kernel, e.g. when using docker, in which case SYS_quotactl_fd might be defined, but might not work at runtime. But I think in this case we can just say to build isolate on the right distro.)
Also, added a better error message for when quotactl fails with ESRCH, because the default one was quite confusing in my opinion.