Skip to content

Conversation

@prandla
Copy link
Contributor

@prandla prandla commented Aug 29, 2025

As mentioned in cms-dev/cms#1530, this is necessary to use tmpfs quotas.

I made it conditional on whether SYS_quotactl_fd is defined. This has been true since kernel 5.14 released around 4 years ago, your choice if you want to keep the old code to support older kernels.

(Also, it's possible that someone might be running a newer distro with an older kernel, e.g. when using docker, in which case SYS_quotactl_fd might be defined, but might not work at runtime. But I think in this case we can just say to build isolate on the right distro.)

Also, added a better error message for when quotactl fails with ESRCH, because the default one was quite confusing in my opinion.

@gollux gollux merged commit 484b2d8 into ioi:master Sep 1, 2025
@gollux
Copy link
Member

gollux commented Sep 1, 2025

Thanks! I will rip out the old code after I check that it's not needed on any system we build packages for.

@prandla prandla deleted the quotactl branch September 3, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants