Skip to content

Conversation

@seniorsolt
Copy link

UI provides the ability to fold and unfold tree elements and a convenient way to look at variables. To avoid making changes to "trace," I use a class attribute "events" to accumulate events tracked through trace, and a class method start() to explicitly start the UI:

import hunter
hunter.trace(action=hunter.actions.UI)

import os
os.path.join('a', 'b')
hunter.stop()
hunter.actions.UI.start()

For the implementation of the UI, I used PyQt5, so the style does not conform to PEP and uses CamelCase for overriding PyQt5 class methods.

I would like to request your review and some feedback.

I'm also unclear about the order of actions when I request to merge. Should I write additional tests, or is it enough to simply run tox on what already exists? Do I need to ensure test coverage in all environments specified in tox.ini?

@seniorsolt seniorsolt marked this pull request as draft September 15, 2024 12:52
@ionelmc
Copy link
Owner

ionelmc commented Jul 9, 2025

Not a bad idea, Hunter could use something like this. But it needs to be completely optional (eg: hunter should be able to run and install without pyqt). This means this needs to live in a completely separate module. I can also be in a completely separate project as well, just saying...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants