Skip to content

Conversation

@anarcat
Copy link

@anarcat anarcat commented May 29, 2025

Closes: #70

@ionelmc
Copy link
Owner

ionelmc commented Jun 2, 2025

I am not really a fan of this approach of ignoring attribute errors and I think in the future it will create more problem than it solves.

Now looking at the traceback I wonder if this problem is not simply caused by manhole trying to import eventlet too eagerly. Would having a check in sys.modules for eventlet (eg: only try to import it if it was already imported) solve your problem? Shouldn't need to import eventlet/gevent if they didn't patch anything anyway (eg: them not being in sys.modules means we get the original stuff). Can you try this approach?

@anarcat
Copy link
Author

anarcat commented Jun 2, 2025 via email

@anarcat
Copy link
Author

anarcat commented Jun 2, 2025

i tried that, let me know if it's what you think. i don't have any gevent or eventlet code here to test this path, but the "normal" path works with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

importing manhole crashes with AttributeError in weird circumstances

2 participants