-
Notifications
You must be signed in to change notification settings - Fork 0
feature: Make changes to package.json for upgrade (RDMR-720, RDMR-721) #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jcesarmobile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resulting package.json gets compressed into a single line. And also some strings get incorrectly escaped, i.e. @capacitor/core turns into @capacitor\/core, I think every / gets converted to \/.
Can it keep the original formatting somehow?
Also, some plugins have ios/ instead of ios/Plugin, in that case probably the ios/Sources and ios/Tests shouldn't need to be added, or ios/ should be deleted.
And also some plugins have ios/Plugin/ (ending in /), which is not being removed at the moment.
If the verify:ios script is not present it should not error as older plugins don't have it, just log a message informing about it.
Yeah, It 100% can, I know what did that. My last minute swap from
I'll make some more checks, this one was shockingly tricky.
Sure thing, that actually makes more sense - that should be a warning at most. |
|
can you resolve the conflicts? |
Done. |
|
@jcesarmobile this should be ready now |
No description provided.