Skip to content

Conversation

@markemer
Copy link
Member

@markemer markemer commented Jul 8, 2025

No description provided.

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resulting package.json gets compressed into a single line. And also some strings get incorrectly escaped, i.e. @capacitor/core turns into @capacitor\/core, I think every / gets converted to \/.
Can it keep the original formatting somehow?

Also, some plugins have ios/ instead of ios/Plugin, in that case probably the ios/Sources and ios/Tests shouldn't need to be added, or ios/ should be deleted.
And also some plugins have ios/Plugin/ (ending in /), which is not being removed at the moment.

If the verify:ios script is not present it should not error as older plugins don't have it, just log a message informing about it.

@markemer
Copy link
Member Author

markemer commented Jul 9, 2025

The resulting package.json gets compressed into a single line. And also some strings get incorrectly escaped, i.e. @capacitor/core turns into @capacitor\/core, I think every / gets converted to \/. Can it keep the original formatting somehow?

Yeah, It 100% can, I know what did that. My last minute swap from rawText to rawData - I should have checked that. If you look at my jsonText var, it does that.

Also, some plugins have ios/ instead of ios/Plugin, in that case probably the ios/Sources and ios/Tests shouldn't need to be added, or ios/ should be deleted. And also some plugins have ios/Plugin/ (ending in /), which is not being removed at the moment.

I'll make some more checks, this one was shockingly tricky.

If the verify:ios script is not present it should not error as older plugins don't have it, just log a message informing about it.

Sure thing, that actually makes more sense - that should be a warning at most.

@markemer markemer requested a review from jcesarmobile July 9, 2025 18:11
@jcesarmobile
Copy link
Member

can you resolve the conflicts?

@markemer
Copy link
Member Author

can you resolve the conflicts?

Done.

@markemer
Copy link
Member Author

@jcesarmobile this should be ready now

@markemer markemer requested a review from jcesarmobile July 18, 2025 20:07
@markemer markemer merged commit 1fe8b05 into main Jul 18, 2025
3 checks passed
@markemer markemer deleted the RDMR-720 branch July 18, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants