refactor(cli): remove usage of @ionic/utils-fs #7762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
EiyuuZack,
IT-MikeS,
andredestro,
eric-horodyski,
markemer,
theproducer and
usernuno
markemer
approved these changes
Nov 19, 2024
eric-horodyski
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ionic/utils-fsis mostly a wrapper aroundfs-extraand uses a very old version of it.Replace usages of the
@ionic/utils-fsfunctions that were just wrappers and use thefs-extraoriginal ones.readdirpwas not a wrapper but a@ionic/utils-fsfunction, so I've created a new simplifiedreaddirpfunction inutils/fsthat does (almost) the same but using node'sreaddirinternally which from node 20 accepts therecursiveoption.