Fix typos and improve documentation across various files #8230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed typo in CHANGELOG.md for Android and CLI regarding Typescript upgrade commit hash. - Corrected variable name from 'statememt' to 'statement' in MockCordovaWebViewImpl.java. - Updated comments and documentation in multiple files to fix spelling errors and improve clarity. - Changed 'overridenUserAgentString' to 'overriddenUserAgentString' in various iOS files for consistency. - Fixed minor typos in HttpRequestHandler.swift and WebViewDelegationHandler.swift. - Corrected test method names in BridgedTypesTests.swift and ConfigurationTests.swift for accuracy.
Member
|
This is kinda neat - let me look into it. some issues.
|
markemer
reviewed
Nov 12, 2025
markemer
reviewed
Nov 12, 2025
markemer
reviewed
Nov 12, 2025
markemer
reviewed
Nov 12, 2025
markemer
reviewed
Nov 12, 2025
markemer
reviewed
Nov 12, 2025
markemer
reviewed
Nov 12, 2025
markemer
reviewed
Nov 12, 2025
markemer
reviewed
Nov 12, 2025
markemer
requested changes
Nov 12, 2025
Member
markemer
left a comment
markemer
left a comment
There was a problem hiding this comment.
SHA changes need a revert to start.
Author
|
@markemer i will revert and add .typo.toml to ensure it doesn't do this |
Reverts the commit hash changes in CHANGELOG files where typos CLI incorrectly modified git commit hashes (e.g., 88d0ded -> 88d0dead). All other legitimate typo fixes from the previous commit are preserved. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Add .typos.toml to prevent typos CLI from incorrectly modifying git commit hashes in CHANGELOG files while still checking for legitimate typos. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Author
|
Hey @markemer we should be all good now do you want i merge the github action check in this one as well ? |
Member
That one is a bigger deal - but this one should be an easy sell. |
Author
|
The GitHub workflow was made only in the doc repo as PR ionic-team/capacitor-docs#481 |
.typos.toml
Outdated
| "ios/Capacitor/Capacitor.xcodeproj/xcshareddata/xcschemes/*.xcscheme", | ||
| "ios-pods-template/**/*.storyboard", | ||
| "ios-spm-template/**/*.storyboard", | ||
| "ios/Capacitor/TestsHostApp/**/*.storyboard", |
Member
There was a problem hiding this comment.
We should exclude CHANGELOG.md so we don't modify any historical context, even if it has typos, IMO.
Member
There was a problem hiding this comment.
I went back and forth on that. Probably ok, but yeah, we should probably exempt them, also would save us the SHA headache.
| "tgz": "application/x-compressed", | ||
| "thmx": "application/vnd.ms-officetheme", | ||
| "thn": "application/octet-stream", | ||
| "then": "application/octet-stream", |
Member
There was a problem hiding this comment.
This should remain thn I believe.
markemer
reviewed
Nov 12, 2025
| "tgz": "application/x-compressed", | ||
| "thmx": "application/vnd.ms-officetheme", | ||
| "thn": "application/octet-stream", | ||
| "then": "application/octet-stream", |
eric-horodyski
requested changes
Nov 12, 2025
…files - Reverts "thn" (Thompson thumbnail format) back from incorrect "then" change - Adds "thn" to typos config to prevent future false positives - Excludes all CHANGELOG files from typos checking - Excludes Xcode project files (pbxproj, xcscheme, storyboard) that contain hex identifiers that should never be modified 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected multiple typos and enhanced clarity in documentation throughout the codebase, ensuring consistency in variable names and comments.
I used typos-cli command to fix them and double checked by hands all was done properly