feat!: initial implementation #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OS-pedrogustavobilro
left a comment
OS-pedrogustavobilro
left a comment
There was a problem hiding this comment.
Overall it looks pretty good! Nice job :D
I left several comments, but some of them are minor, others may require changes.
src/main/kotlin/io/ionic/libs/ionfiletransferlib/IONFLTRController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/ionfiletransferlib/IONFLTRController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/ionfiletransferlib/helpers/IONFLTRInputsValidator.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/ionfiletransferlib/helpers/IONFLTRFileHelper.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/ionfiletransferlib/IONFLTRController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/ionfiletransferlib/IONFLTRController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/ionfiletransferlib/IONFLTRController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/ionfiletransferlib/IONFLTRController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/ionfiletransferlib/IONFLTRController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/ionfiletransferlib/IONFLTRController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/ionfiletransferlib/IONFLTRController.kt
Outdated
Show resolved
Hide resolved
To avoid runtime error PR comment: #1 (comment)
PR comment: #1 (comment)
src/main/kotlin/io/ionic/libs/ionfiletransferlib/IONFLTRController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/ionfiletransferlib/IONFLTRController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/ionfiletransferlib/IONFLTRController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/ionfiletransferlib/helpers/IONFLTRFileHelper.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/ionfiletransferlib/helpers/IONFLTRFileHelper.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/ionfiletransferlib/helpers/IONFLTRInputsValidator.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/ionfiletransferlib/helpers/IONFLTRInputsValidator.kt
Outdated
Show resolved
Hide resolved
|
Just noticed this and not super important but is there a typo in the PR title? It's |
src/main/kotlin/io/ionic/libs/ionfiletransferlib/model/IONFLTRException.kt
Outdated
Show resolved
Hide resolved
Collaborator
Author
The exclamation point is just to say it's a breaking change so when we do semantic release it will release 1.0.0 |
TIL! I suspected it could be something related with that, but wasn't sure, thanks for clarifying! |
alexgerardojacinto
approved these changes
Apr 22, 2025
andredestro
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial implementation for the Android File Transfer Plugin.
downloadFileanduploadFilemethodsType of changes
Tests
N/A
Checklist