Skip to content

chore: rename lib to IONGeolocationLib-iOS #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexgerardojacinto merged 2 commits into from
Jan 22, 2025
Merged

chore: rename lib to IONGeolocationLib-iOS #2

alexgerardojacinto merged 2 commits into from
Jan 22, 2025

Conversation

@alexgerardojacinto
Copy link
Contributor

@alexgerardojacinto alexgerardojacinto commented Jan 20, 2025 •
edited
Loading

Description

  • As agreed, we're changing the prefix in the name of the library from OS to ION.
  • Changed repository name to IONGeolocation-iOS

Context

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality to not work as expected)

Platforms affected

  • [] Android
  • iOS
  • JavaScript

Tests

All unit tests passing.

Screenshots (if appropriate)

Checklist

  • Code follows code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
    • Documentation has been updated accordingly

@alexgerardojacinto alexgerardojacinto changed the base branch from main to development January 20, 2025 15:27
@alexgerardojacinto alexgerardojacinto changed the title Feat/rmet 3997/rename lib chore: rename lib to IONGeolocationLib-iOS Jan 20, 2025
@alexgerardojacinto alexgerardojacinto self-assigned this Jan 20, 2025
@alexgerardojacinto alexgerardojacinto marked this pull request as ready for review January 20, 2025 15:37
@alexgerardojacinto alexgerardojacinto changed the title chore: rename lib to IONGeolocationLib-iOS chore: rename lib to IONGeolocationLib-iOS Jan 20, 2025
OS-pedrogustavobilro
OS-pedrogustavobilro approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@OS-pedrogustavobilro OS-pedrogustavobilro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this PR is merged, the Github repository name can be updated right?

@alexgerardojacinto
Copy link
Contributor Author

alexgerardojacinto commented Jan 21, 2025 •
edited
Loading

After this PR is merged, the Github repository name can be updated right?

Yes that's the plan, only change the repo's name when this is merged. Same thing for the Android library.

@OS-pedrogustavobilro OS-pedrogustavobilro mentioned this pull request Jan 21, 2025
Merged
OS-ricardomoreirasilva
OS-ricardomoreirasilva reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@OS-ricardomoreirasilva OS-ricardomoreirasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the README file missing?

@alexgerardojacinto
Copy link
Contributor Author

alexgerardojacinto commented Jan 21, 2025

Isn't the README file missing?

@OS-ricardomoreirasilva the README file is included in the changes, as I changed the references of OSGeolocationLib-iOS with IONGeolocationLib-iOS. Did I miss anything?

@OS-ricardomoreirasilva
Copy link
Contributor

OS-ricardomoreirasilva commented Jan 22, 2025

Isn't the README file missing?

@OS-ricardomoreirasilva the README file is included in the changes, as I changed the references of OSGeolocationLib-iOS with IONGeolocationLib-iOS. Did I miss anything?

Wasn't showing for some reason 🤷

@alexgerardojacinto alexgerardojacinto merged commit 6a68ae1 into development Jan 22, 2025
1 check passed
@alexgerardojacinto alexgerardojacinto deleted the feat/RMET-3997/rename-lib branch January 23, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OS-pedrogustavobilro OS-pedrogustavobilro OS-pedrogustavobilro approved these changes

@ItsChaceD ItsChaceD Awaiting requested review from ItsChaceD

@IT-MikeS IT-MikeS Awaiting requested review from IT-MikeS

@OS-martacarlos OS-martacarlos Awaiting requested review from OS-martacarlos

@eric-horodyski eric-horodyski Awaiting requested review from eric-horodyski

+1 more reviewer

@OS-ricardomoreirasilva OS-ricardomoreirasilva OS-ricardomoreirasilva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexgerardojacinto alexgerardojacinto

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexgerardojacinto @OS-ricardomoreirasilva @OS-pedrogustavobilro