Skip to content

fix: check if location service is already monitoring location when single location is requested #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OS-ruimoreiramendes merged 1 commit into from
Aug 11, 2025
Merged

fix: check if location service is already monitoring location when single location is requested #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions IONGeolocationLib/Publishers/IONGLOCManagerWrapper.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public class IONGLOCManagerWrapper: NSObject, IONGLOCService {

@Published public var currentLocation: IONGLOCPositionModel?
public var currentLocationPublisher: AnyPublisher<IONGLOCPositionModel, IONGLOCLocationError> {
$currentLocation
Publishers.Merge($currentLocation, currentLocationForceSubject)
.dropFirst() // ignore the first value as it's the one set on the constructor.
.tryMap { location in
guard let location else { throw IONGLOCLocationError.locationUnavailable }
Expand All @@ -26,9 +26,13 @@ public class IONGLOCManagerWrapper: NSObject, IONGLOCService {
.mapError { $0 as? IONGLOCLocationError ?? .other($0) }
.eraseToAnyPublisher()
}

private let currentLocationForceSubject = PassthroughSubject<IONGLOCPositionModel?, Never>()

private let locationManager: CLLocationManager
private let servicesChecker: IONGLOCServicesChecker

private var isMonitoringLocation = false

public init(locationManager: CLLocationManager = .init(), servicesChecker: IONGLOCServicesChecker = IONGLOCServicesValidator()) {
self.locationManager = locationManager
Expand All @@ -44,14 +48,23 @@ public class IONGLOCManagerWrapper: NSObject, IONGLOCService {
}

public func startMonitoringLocation() {
isMonitoringLocation = true
locationManager.startUpdatingLocation()
}

public func stopMonitoringLocation() {
isMonitoringLocation = false
locationManager.stopUpdatingLocation()
}

public func requestSingleLocation() {
// If monitoring is active meaning the location service is already running
// and calling .requestLocation() will not trigger a new location update,
// we can just return the current location.
if isMonitoringLocation, let location = currentLocation {
currentLocationForceSubject.send(location)
return
}
locationManager.requestLocation()
}

Expand Down
Loading