-
Notifications
You must be signed in to change notification settings - Fork 3.2k
docs(checkbox): add helperText and errorText section #4028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5af3157
docs(checkbox): add helperText and errorText section
thetaPC 85e39d5
fix(checkbox): clean up demo
thetaPC 2adff21
chore(checkbox): use dev build
thetaPC f863e26
Update static/usage/v8/checkbox/helper-error/react.md
thetaPC 5e0c99b
Update static/usage/v8/checkbox/helper-error/angular/example_componen…
thetaPC 53e9e14
Update static/usage/v8/checkbox/helper-error/demo.html
thetaPC 35a7a78
Update static/usage/v8/checkbox/helper-error/javascript.md
thetaPC 4a03051
Update static/usage/v8/checkbox/helper-error/vue.md
thetaPC b2d6cff
chore(checkbox): run lint
thetaPC defaad5
chore(checkbox): remove dev build
thetaPC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "dependencies": { | ||
| "@ionic/core": "8.4.1", | ||
| "@ionic/core": "8.4.4-dev.11741206641.18dd4e91", | ||
| "ionicons": "7.4.0" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
static/usage/v8/checkbox/helper-error/angular/example_component_html.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| ```html | ||
| <form [formGroup]="myForm" (ngSubmit)="onSubmit()"> | ||
| <ion-checkbox formControlName="agree" helperText="This needs to be checked" errorText="This field is required"> | ||
| I agree to the terms and conditions | ||
| </ion-checkbox> | ||
|
|
||
| <br /> | ||
|
|
||
| <ion-button type="submit" size="small">Submit</ion-button> | ||
| </form> | ||
| ``` | ||
29 changes: 29 additions & 0 deletions
29
static/usage/v8/checkbox/helper-error/angular/example_component_ts.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| ```ts | ||
| import { Component } from '@angular/core'; | ||
| import { FormBuilder, FormGroup, Validators, ReactiveFormsModule } from '@angular/forms'; | ||
| import { IonCheckbox, IonButton } from '@ionic/angular/standalone'; | ||
|
|
||
| @Component({ | ||
| selector: 'app-example', | ||
| standalone: true, | ||
| imports: [IonCheckbox, IonButton, ReactiveFormsModule], | ||
| templateUrl: './example.component.html', | ||
| styleUrl: './example.component.css', | ||
| }) | ||
| export class ExampleComponent { | ||
| myForm: FormGroup; | ||
|
|
||
| constructor(private fb: FormBuilder) { | ||
| this.myForm = this.fb.group({ | ||
| agree: [false, Validators.requiredTrue], | ||
| }); | ||
| } | ||
|
|
||
| onSubmit() { | ||
| // Mark the control as touched to trigger the error message. | ||
| // This is needed if the user submits the form without interacting | ||
| // with the checkbox. | ||
| this.myForm.get('agree')!.markAsTouched(); | ||
| } | ||
| } | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Input</title> | ||
| <link rel="stylesheet" href="../../common.css" /> | ||
| <script src="../../common.js"></script> | ||
| <script | ||
| type="module" | ||
| src="https://cdn.jsdelivr.net/npm/@ionic/[email protected]/dist/ionic/ionic.esm.js" | ||
| ></script> | ||
| <link | ||
| rel="stylesheet" | ||
| href="https://cdn.jsdelivr.net/npm/@ionic/[email protected]/css/ionic.bundle.css" | ||
| /> | ||
| </head> | ||
|
|
||
| <body> | ||
| <div class="container"> | ||
| <form id="my-form"> | ||
| <ion-checkbox helper-text="This needs to be checked" error-text="This field is required"> | ||
thetaPC marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| I agree to the terms and conditions | ||
| </ion-checkbox> | ||
|
|
||
| <br /> | ||
|
|
||
| <ion-button type="submit" size="small">Submit</ion-button> | ||
| </form> | ||
| </div> | ||
|
|
||
| <script> | ||
| const form = document.getElementById('my-form'); | ||
| const agree = form.querySelector('ion-checkbox'); | ||
|
|
||
| form.addEventListener('submit', (event) => submit(event)); | ||
| agree.addEventListener('ionChange', (event) => validateCheckbox(event)); | ||
|
|
||
| const validateCheckbox = (event) => { | ||
| agree.classList.add('ion-touched'); | ||
|
|
||
| if (!event.detail.checked) { | ||
| agree.classList.add('ion-invalid'); | ||
| agree.classList.remove('ion-valid'); | ||
| } else { | ||
| agree.classList.remove('ion-invalid'); | ||
| agree.classList.add('ion-valid'); | ||
| } | ||
| }; | ||
|
|
||
| const submit = (event) => { | ||
| event.preventDefault(); | ||
|
|
||
| validateCheckbox({ detail: { checked: agree.checked } }); | ||
| }; | ||
| </script> | ||
| </body> | ||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import Playground from '@site/src/components/global/Playground'; | ||
|
|
||
| import javascript from './javascript.md'; | ||
| import react from './react.md'; | ||
| import vue from './vue.md'; | ||
|
|
||
| import angular_example_component_html from './angular/example_component_html.md'; | ||
| import angular_example_component_ts from './angular/example_component_ts.md'; | ||
|
|
||
| <Playground | ||
| version="8" | ||
| code={{ | ||
| javascript, | ||
| react, | ||
| vue, | ||
| angular: { | ||
| files: { | ||
| 'src/app/example.component.html': angular_example_component_html, | ||
| 'src/app/example.component.ts': angular_example_component_ts, | ||
| }, | ||
| }, | ||
| }} | ||
| src="usage/v8/checkbox/helper-error/demo.html" | ||
| /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| ```html | ||
| <form id="my-form"> | ||
| <ion-checkbox helper-text="This needs to be checked" error-text="This field is required"> | ||
thetaPC marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| I agree to the terms and conditions | ||
| </ion-checkbox> | ||
|
|
||
| <br /> | ||
|
|
||
| <ion-button type="submit" size="small">Submit</ion-button> | ||
| </form> | ||
|
|
||
| <script> | ||
| const form = document.getElementById('my-form'); | ||
| const agree = form.querySelector('ion-checkbox'); | ||
|
|
||
| form.addEventListener('submit', (event) => submit(event)); | ||
| agree.addEventListener('ionChange', (event) => validateCheckbox(event)); | ||
|
|
||
| const validateCheckbox = (event) => { | ||
| agree.classList.add('ion-touched'); | ||
|
|
||
| if (!event.detail.checked) { | ||
| agree.classList.add('ion-invalid'); | ||
| agree.classList.remove('ion-valid'); | ||
| } else { | ||
| agree.classList.remove('ion-invalid'); | ||
| agree.classList.add('ion-valid'); | ||
| } | ||
| }; | ||
|
|
||
| const submit = (event) => { | ||
| event.preventDefault(); | ||
|
|
||
| validateCheckbox({ detail: { checked: agree.checked } }); | ||
| }; | ||
| </script> | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| ```tsx | ||
| import React, { useRef, useState } from 'react'; | ||
| import { IonCheckbox, IonButton, CheckboxCustomEvent } from '@ionic/react'; | ||
|
|
||
| function Example() { | ||
| const [isTouched, setIsTouched] = useState<boolean>(false); | ||
| const [isValid, setIsValid] = useState<boolean | undefined>(); | ||
|
|
||
| const agreeRef = useRef<HTMLIonCheckboxElement>(null); | ||
|
|
||
| const validateCheckbox = (event: CheckboxCustomEvent<{ checked: boolean }>) => { | ||
| setIsTouched(true); | ||
| setIsValid(event.detail.checked); | ||
| }; | ||
|
|
||
| const submit = (event: React.FormEvent<HTMLFormElement>) => { | ||
| event.preventDefault(); | ||
|
|
||
| if (agreeRef.current) { | ||
| validateCheckbox({ detail: { checked: agreeRef.current.checked } } as CheckboxCustomEvent<{ | ||
| checked: boolean; | ||
| }>); | ||
| } | ||
| }; | ||
|
|
||
| return ( | ||
| <> | ||
| <form onSubmit={submit}> | ||
| <IonCheckbox | ||
| ref={agreeRef} | ||
| className={`${isValid ? 'ion-valid' : ''} ${isValid === false ? 'ion-invalid' : ''} ${ | ||
| isTouched ? 'ion-touched' : '' | ||
| }`} | ||
| helperText="This needs to be checked" | ||
| errorText="This field is required" | ||
thetaPC marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| onIonChange={(event) => validateCheckbox(event)} | ||
| > | ||
| I agree to the terms and conditions | ||
| </IonCheckbox> | ||
|
|
||
| <br /> | ||
|
|
||
| <IonButton type="submit" size="small"> | ||
| Submit | ||
| </IonButton> | ||
| </form> | ||
| </> | ||
| ); | ||
| } | ||
|
|
||
| export default Example; | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| ```html | ||
| <template> | ||
| <form @submit.prevent="submit"> | ||
| <ion-checkbox | ||
| v-model="agree" | ||
| helper-text="This needs to be checked" | ||
| error-text="This field is required" | ||
thetaPC marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| @ionChange="validateCheckbox" | ||
| :class="{ 'ion-valid': isValid, 'ion-invalid': isValid === false, 'ion-touched': isTouched }" | ||
| > | ||
| I agree to the terms and conditions | ||
| </ion-checkbox> | ||
|
|
||
| <br /> | ||
|
|
||
| <ion-button type="submit" size="small">Submit</ion-button> | ||
| </form> | ||
| </template> | ||
|
|
||
| <script lang="ts"> | ||
| import { defineComponent, ref } from 'vue'; | ||
| import { IonCheckbox, IonButton, CheckboxCustomEvent } from '@ionic/vue'; | ||
|
|
||
| export default defineComponent({ | ||
| components: { | ||
| IonCheckbox, | ||
| IonButton, | ||
| }, | ||
| setup() { | ||
| const agree = ref(false); | ||
| const isTouched = ref(false); | ||
| const isValid = ref<boolean | undefined>(); | ||
|
|
||
| const validateCheckbox = (event: CheckboxCustomEvent<{ checked: boolean }>) => { | ||
| isTouched.value = true; | ||
| isValid.value = event.detail.checked; | ||
| }; | ||
|
|
||
| const submit = () => { | ||
| validateCheckbox({ detail: { checked: agree.value } } as CheckboxCustomEvent<{ checked: boolean }>); | ||
| }; | ||
|
|
||
| return { | ||
| agree, | ||
| isTouched, | ||
| isValid, | ||
| validateCheckbox, | ||
| submit, | ||
| }; | ||
| }, | ||
| }); | ||
| </script> | ||
| ``` | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.