-
Notifications
You must be signed in to change notification settings - Fork 3.2k
docs(toggle): add helperText and errorText section #4033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
def00f6
docs(toggle): add helperText and errorText section
thetaPC 74feb87
chore(toggle): run lint
thetaPC b741840
chore(toggle): use dev build
thetaPC 927c64f
Update static/usage/v8/toggle/helper-error/demo.html
thetaPC 1510b82
Update static/usage/v8/toggle/helper-error/javascript.md
thetaPC 1842e6e
Update static/usage/v8/toggle/helper-error/react.md
thetaPC ec266be
Update static/usage/v8/toggle/helper-error/vue.md
thetaPC 46dbaef
Update static/usage/v8/toggle/helper-error/angular/example_component_…
thetaPC 1db35be
Update static/usage/v8/toggle/helper-error/angular/example_component_…
thetaPC e36e941
chore(toggle): run lint
thetaPC 517c08c
fix(toggle): use correct label text
thetaPC 5f40e6d
chore(toggle): remove dev build
thetaPC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"dependencies": { | ||
"@ionic/core": "8.4.1", | ||
"@ionic/core": "8.4.4-dev.11741630999.189d7fc2", | ||
"ionicons": "7.4.0" | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
static/usage/v8/toggle/helper-error/angular/example_component_html.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
```html | ||
<form [formGroup]="myForm" (ngSubmit)="onSubmit()"> | ||
<ion-toggle formControlName="wifi" helperText="This needs to be enabled" errorText="This field is required"> | ||
Wi-Fi | ||
</ion-toggle> | ||
|
||
<br /> | ||
|
||
<ion-button type="submit" size="small">Submit</ion-button> | ||
</form> | ||
``` |
29 changes: 29 additions & 0 deletions
29
static/usage/v8/toggle/helper-error/angular/example_component_ts.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
```ts | ||
import { Component } from '@angular/core'; | ||
import { FormBuilder, FormGroup, Validators, ReactiveFormsModule } from '@angular/forms'; | ||
import { IonToggle, IonButton } from '@ionic/angular/standalone'; | ||
|
||
@Component({ | ||
selector: 'app-example', | ||
standalone: true, | ||
imports: [IonToggle, IonButton, ReactiveFormsModule], | ||
templateUrl: './example.component.html', | ||
styleUrl: './example.component.css', | ||
}) | ||
export class ExampleComponent { | ||
myForm: FormGroup; | ||
|
||
constructor(private fb: FormBuilder) { | ||
this.myForm = this.fb.group({ | ||
wifi: [false, Validators.requiredTrue], | ||
}); | ||
} | ||
|
||
onSubmit() { | ||
// Mark the control as touched to trigger the error message. | ||
// This is needed if the user submits the form without interacting | ||
// with the toggle. | ||
this.myForm.get('wifi')!.markAsTouched(); | ||
} | ||
} | ||
thetaPC marked this conversation as resolved.
Show resolved
Hide resolved
|
||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="UTF-8" /> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
<title>Input</title> | ||
<link rel="stylesheet" href="../../common.css" /> | ||
<script src="../../common.js"></script> | ||
<script | ||
type="module" | ||
src="https://cdn.jsdelivr.net/npm/@ionic/[email protected]/dist/ionic/ionic.esm.js" | ||
></script> | ||
<link | ||
rel="stylesheet" | ||
href="https://cdn.jsdelivr.net/npm/@ionic/[email protected]/css/ionic.bundle.css" | ||
/> | ||
</head> | ||
|
||
<body> | ||
<div class="container"> | ||
<form id="my-form"> | ||
<ion-toggle helper-text="This needs to be enabled" error-text="This field is required"> Wi-Fi </ion-toggle> | ||
|
||
<br /> | ||
|
||
<ion-button type="submit" size="small">Submit</ion-button> | ||
</form> | ||
</div> | ||
|
||
<script> | ||
const form = document.getElementById('my-form'); | ||
const wifi = form.querySelector('ion-toggle'); | ||
|
||
form.addEventListener('submit', (event) => submit(event)); | ||
wifi.addEventListener('ionChange', (event) => validateToggle(event)); | ||
|
||
const validateToggle = (event) => { | ||
wifi.classList.add('ion-touched'); | ||
|
||
if (!event.detail.checked) { | ||
wifi.classList.add('ion-invalid'); | ||
wifi.classList.remove('ion-valid'); | ||
} else { | ||
wifi.classList.remove('ion-invalid'); | ||
wifi.classList.add('ion-valid'); | ||
} | ||
}; | ||
|
||
const submit = (event) => { | ||
event.preventDefault(); | ||
|
||
validateToggle({ detail: { checked: wifi.checked } }); | ||
}; | ||
</script> | ||
</body> | ||
thetaPC marked this conversation as resolved.
Show resolved
Hide resolved
|
||
</html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
import Playground from '@site/src/components/global/Playground'; | ||
|
||
import javascript from './javascript.md'; | ||
import react from './react.md'; | ||
import vue from './vue.md'; | ||
|
||
import angular_example_component_html from './angular/example_component_html.md'; | ||
import angular_example_component_ts from './angular/example_component_ts.md'; | ||
|
||
<Playground | ||
version="8" | ||
code={{ | ||
javascript, | ||
react, | ||
vue, | ||
angular: { | ||
files: { | ||
'src/app/example.component.html': angular_example_component_html, | ||
'src/app/example.component.ts': angular_example_component_ts, | ||
}, | ||
}, | ||
}} | ||
src="usage/v8/toggle/helper-error/demo.html" | ||
/> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
```html | ||
<form id="my-form"> | ||
<ion-toggle helper-text="This needs to be enabled" error-text="This field is required"> Wi-Fi </ion-toggle> | ||
|
||
<br /> | ||
|
||
<ion-button type="submit" size="small">Submit</ion-button> | ||
</form> | ||
|
||
<script> | ||
const form = document.getElementById('my-form'); | ||
const wifi = form.querySelector('ion-toggle'); | ||
|
||
form.addEventListener('submit', (event) => submit(event)); | ||
wifi.addEventListener('ionChange', (event) => validateToggle(event)); | ||
|
||
const validateToggle = (event) => { | ||
wifi.classList.add('ion-touched'); | ||
|
||
if (!event.detail.checked) { | ||
wifi.classList.add('ion-invalid'); | ||
wifi.classList.remove('ion-valid'); | ||
} else { | ||
wifi.classList.remove('ion-invalid'); | ||
wifi.classList.add('ion-valid'); | ||
} | ||
}; | ||
|
||
const submit = (event) => { | ||
event.preventDefault(); | ||
|
||
validateToggle({ detail: { checked: wifi.checked } }); | ||
}; | ||
</script> | ||
thetaPC marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
```tsx | ||
import React, { useRef, useState } from 'react'; | ||
import { IonToggle, IonButton, ToggleCustomEvent } from '@ionic/react'; | ||
|
||
function Example() { | ||
const [isTouched, setIsTouched] = useState<boolean>(false); | ||
const [isValid, setIsValid] = useState<boolean | undefined>(); | ||
|
||
const wifiRef = useRef<HTMLIonToggleElement>(null); | ||
|
||
const validateToggle = (event: ToggleCustomEvent<{ checked: boolean }>) => { | ||
setIsTouched(true); | ||
setIsValid(event.detail.checked); | ||
}; | ||
|
||
const submit = (event: React.FormEvent<HTMLFormElement>) => { | ||
event.preventDefault(); | ||
|
||
if (wifiRef.current) { | ||
validateToggle({ detail: { checked: wifiRef.current.checked } } as ToggleCustomEvent<{ | ||
checked: boolean; | ||
}>); | ||
} | ||
}; | ||
|
||
return ( | ||
<> | ||
<form onSubmit={submit}> | ||
<IonToggle | ||
ref={wifiRef} | ||
className={`${isValid ? 'ion-valid' : ''} ${isValid === false ? 'ion-invalid' : ''} ${ | ||
isTouched ? 'ion-touched' : '' | ||
}`} | ||
helperText="This needs to be enabled" | ||
errorText="This field is required" | ||
onIonChange={(event) => validateToggle(event)} | ||
> | ||
I agree to the terms and conditions | ||
</IonToggle> | ||
|
||
<br /> | ||
|
||
<IonButton type="submit" size="small"> | ||
Submit | ||
</IonButton> | ||
</form> | ||
</> | ||
); | ||
} | ||
|
||
export default Example; | ||
thetaPC marked this conversation as resolved.
Show resolved
Hide resolved
|
||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
```html | ||
<template> | ||
<form @submit.prevent="submit"> | ||
<ion-toggle | ||
v-model="wifi" | ||
helper-text="This needs to be enabled" | ||
error-text="This field is required" | ||
@ionChange="validateToggle" | ||
:class="{ 'ion-valid': isValid, 'ion-invalid': isValid === false, 'ion-touched': isTouched }" | ||
> | ||
Wi-Fi | ||
</ion-toggle> | ||
|
||
<br /> | ||
|
||
<ion-button type="submit" size="small">Submit</ion-button> | ||
</form> | ||
</template> | ||
|
||
<script lang="ts"> | ||
import { defineComponent, ref } from 'vue'; | ||
import { IonToggle, IonButton, ToggleCustomEvent } from '@ionic/vue'; | ||
|
||
export default defineComponent({ | ||
components: { | ||
IonToggle, | ||
IonButton, | ||
}, | ||
setup() { | ||
const wifi = ref(false); | ||
const isTouched = ref(false); | ||
const isValid = ref<boolean | undefined>(); | ||
|
||
const validateToggle = (event: ToggleCustomEvent<{ checked: boolean }>) => { | ||
isTouched.value = true; | ||
isValid.value = event.detail.checked; | ||
}; | ||
|
||
const submit = () => { | ||
validateToggle({ detail: { checked: wifi.value } } as ToggleCustomEvent<{ checked: boolean }>); | ||
}; | ||
|
||
return { | ||
wifi, | ||
isTouched, | ||
isValid, | ||
validateToggle, | ||
submit, | ||
}; | ||
}, | ||
}); | ||
</script> | ||
thetaPC marked this conversation as resolved.
Show resolved
Hide resolved
|
||
``` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.