Skip to content

Commit b914f86

Browse files
committed
refactor(overlays): more commenting
1 parent 4cdb33a commit b914f86

File tree

1 file changed

+16
-15
lines changed

1 file changed

+16
-15
lines changed

core/src/utils/overlays.ts

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -524,7 +524,7 @@ export const present = async <OverlayPresentOptions>(
524524
document.body.classList.add(BACKDROP_NO_SCROLL);
525525

526526
hideUnderlyingOverlaysFromScreenReaders(overlay.el);
527-
// hideAnimatingOverlayFromScreenReaders(overlay.el);
527+
hideAnimatingOverlayFromScreenReaders(overlay.el);
528528

529529
overlay.presented = true;
530530
overlay.willPresent.emit();
@@ -677,7 +677,7 @@ export const dismiss = async <OverlayDismissOptions>(
677677
* the dismiss animation. This is because the overlay will be removed
678678
* from the DOM after the animation is complete.
679679
*/
680-
// hideAnimatingOverlayFromScreenReaders(overlay.el);
680+
hideAnimatingOverlayFromScreenReaders(overlay.el);
681681

682682
// Overlay contents should not be clickable during dismiss
683683
overlay.el.style.setProperty('pointer-events', 'none');
@@ -977,19 +977,20 @@ export const createTriggerController = () => {
977977
*
978978
* @param overlay - The overlay that is being animated.
979979
*/
980-
// const hideAnimatingOverlayFromScreenReaders = (overlay: HTMLIonOverlayElement) => {
981-
// if (doc === undefined) return;
982-
983-
// const mode = getIonMode(overlay);
984-
985-
// if (mode === 'md') {
986-
// /**
987-
// * Once the animation is complete, this attribute will be removed.
988-
// * This is done at the end of the `present` method.
989-
// */
990-
// overlay.setAttribute('aria-hidden', 'true');
991-
// }
992-
// };
980+
const hideAnimatingOverlayFromScreenReaders = (overlay: HTMLIonOverlayElement) => {
981+
if (doc === undefined) return;
982+
983+
const mode = getIonMode(overlay);
984+
console.log('mode', mode);
985+
986+
// if (mode === 'md') {
987+
// /**
988+
// * Once the animation is complete, this attribute will be removed.
989+
// * This is done at the end of the `present` method.
990+
// */
991+
// overlay.setAttribute('aria-hidden', 'true');
992+
// }
993+
};
993994

994995
/**
995996
* Ensure that underlying overlays have aria-hidden if necessary so that screen readers

0 commit comments

Comments
 (0)