Commit f9a936b
fix(tokens): remove style dictionary scripts and reuse os tokens logic (#30786)
Issue number: internal
---------
<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->
<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->
## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->
This pull request updates the design token build system and its
dependencies, simplifying the process and removing custom scripts in
favor of using the latest features of the `outsystems-design-tokens`
package. The changes modernize how design tokens are generated and
maintained, reducing custom code and leveraging upstream improvements.
Key changes include:
**Build Process Simplification:**
- The custom design token generation scripts
(`core/scripts/tokens/index.mjs` and `core/scripts/tokens/utils.mjs`)
have been removed. Token generation is now handled directly via the
`outsystems-design-tokens` package using an `npx` command in the
`build.tokens` script. This reduces maintenance overhead and keeps the
build process aligned with upstream best practices.
[[1]](diffhunk://#diff-0b9870c62ff80af860467e2541bba0b9ba5e7280b12bea6eeb124b1d174efbcfL1-L188)
[[2]](diffhunk://#diff-8b5c339d9dd13300954577213f84a443321a0d6477acd7553787fbcc00ce8cabL1-L320)
[[3]](diffhunk://#diff-7f67769260741e2563407af949f7e54fbf0431d1c607933f6e8a8094e3219e26L83-R82)
**Dependency Updates:**
- Updated `outsystems-design-tokens` to version `1.3.3` and
`style-dictionary` to version `5.1.1` in both `package.json` and
`package-lock.json`. This ensures compatibility with the latest features
and bug fixes and removes the need to specify `style-dictionary`
directly as a dependency.
[[1]](diffhunk://#diff-4ff996db8bece1eded512c3b97a6bde33622f94bb387634ef32496d832d57744L47-L52)
[[2]](diffhunk://#diff-4ff996db8bece1eded512c3b97a6bde33622f94bb387634ef32496d832d57744L9592-R9598)
[[3]](diffhunk://#diff-4ff996db8bece1eded512c3b97a6bde33622f94bb387634ef32496d832d57744L11137-R11138)
[[4]](diffhunk://#diff-7f67769260741e2563407af949f7e54fbf0431d1c607933f6e8a8094e3219e26L69-L74)
**SCSS Utility Import:**
- The `@forward "../../foundations/ionic.utility";` statement was
removed from `core/src/css/ionic/utils.bundle.ionic.scss`, likely
because the utility SCSS is now generated and managed by the new token
build process.
Removed CSS tests for Ionic theme, as they relied heavily on testing the
effect of the utility-classes, that are no longer created on the ionic
scope.
## Does this introduce a breaking change?
- [ ] Yes
- [x] No
<!--
If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->
---------
Co-authored-by: ionitron <[email protected]>1 parent 2b0a423 commit f9a936b
File tree
425 files changed
+332
-4644
lines changed- core
- scripts
- testing
- tokens
- src
- components
- accordion/test/multiple/accordion.e2e.ts-snapshots
- avatar/test/size/avatar.e2e.ts-snapshots
- badge/test/hint/badge.e2e.ts-snapshots
- button/test
- basic/button.e2e.ts-snapshots
- clear/button.e2e.ts-snapshots
- outline/button.e2e.ts-snapshots
- shape/button.e2e.ts-snapshots
- size/button.e2e.ts-snapshots
- spinner/button.e2e.ts-snapshots
- states/button.e2e.ts-snapshots
- card/test/shape/card.e2e.ts-snapshots
- chip/test/states/chip.e2e.ts-snapshots
- datetime/test
- basic/datetime.e2e.ts-snapshots
- display/datetime.e2e.ts-snapshots
- show-adjacent-days/datetime.e2e.ts-snapshots
- header/test/fade/header.e2e.ts-snapshots
- item-sliding/test
- basic/item-sliding.e2e.ts-snapshots
- hue/item-sliding.e2e.ts-snapshots
- icons/item-sliding.e2e.ts-snapshots
- shapes/item-sliding.e2e.ts-snapshots
- states/item-sliding.e2e.ts-snapshots
- item/test/disabled/item.e2e.ts-snapshots
- list-header/test/basic/list-header.e2e.ts-snapshots
- modal/test
- basic/modal.e2e.ts-snapshots
- shape/modal.e2e.ts-snapshots
- sheet/modal.e2e.ts-snapshots
- radio/test/states/radio.e2e.ts-snapshots
- range/test/basic/range.e2e.ts-snapshots
- segment/test
- layout/segment.e2e.ts-snapshots
- states/segment.e2e.ts-snapshots
- select-modal/test/basic/select-modal.e2e.ts-snapshots
- tab-bar/test
- basic/tab-bar.e2e.ts-snapshots
- expand/tab-bar.e2e.ts-snapshots
- shape/tab-bar.e2e.ts-snapshots
- tab-button/test/shape/tab-button.e2e.ts-snapshots
- title/test/basic/title.e2e.ts-snapshots
- toast/test
- basic/toast.e2e.ts-snapshots
- hue/toast.e2e.ts-snapshots
- shape/toast.e2e.ts-snapshots
- toggle/test/sizes/toggle.e2e.ts-snapshots
- toolbar/test/basic/toolbar.e2e.ts-snapshots
- css
- ionic
- test
- link/basic
- link.e2e.ts-snapshots
- typography/basic
- typography.e2e.ts-snapshots
- foundations
- utils/test/playwright/page/utils
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
425 files changed
+332
-4644
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
75 | 74 | | |
76 | 75 | | |
77 | 76 | | |
| |||
80 | 79 | | |
81 | 80 | | |
82 | 81 | | |
83 | | - | |
| 82 | + | |
84 | 83 | | |
85 | 84 | | |
86 | 85 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
51 | 60 | | |
52 | 61 | | |
53 | 62 | | |
| |||
This file was deleted.
0 commit comments