fix(item-sliding): check for side attribute to avoid an undefined value
#29845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mbruegmann
approved these changes
May 23, 2025
|
@brandyscarney what's the status of this PR? |
|
@thetaPC The fix works but I wanted to find a way to add a test for it but haven't had time to look into it. |
This reverts commit e681558.
ShaneK
approved these changes
Jun 10, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
Adds test for #29845 Must be merged after the fix in that PR is released. The test will fail while using the older version of the CDN. --------- Co-authored-by: Brandy Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29499
What is the current behavior?
Using the bundled version of Ionic results in an error
Uncaught (in promise) Error: "undefined" is not a valid value for [side]. Use "start" or "end" instead.with<ion-item-sliding>.Reproduction 1:
+) button several timesIt is also reproducible in an Ionic Angular app when installed via npm.
Reproduction 2:
Add Itemsbutton several timesWhat is the new behavior?
Check for the side attribute to avoid
sidebeingundefined.Does this introduce a breaking change?
Other information
Dev build:
8.6.1-dev.11749562115.1e681558Test PR: #30469
The tests must be merged separately, after this is released, in order to use the fix from the CDN.