feat(backdrop): ionic theme styles #29873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
approved these changes
Sep 13, 2024
BenOsodrac
reviewed
Sep 16, 2024
|
@brandyscarney Also re-request review from you since I made a change in my latest commit. The blur effect wasn't apply on desktop browsers, so I changed how the background color and opacity are set so it's visible in the preview links now |
brandyscarney
approved these changes
Sep 16, 2024
BenOsodrac
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
No Ionic theme styles for the
ion-backdropelementWhat is the new behavior?
Adds Ionic theme styles for
ion-backdropand updates snapshots.Does this introduce a breaking change?
Other information
The backdrop changes were only applied to
ion-modalfor now as all other components whereion-backdropis used do not yet have dedicated Ionic theme styles. This is relevant as those components will need to set--backdrop-opacity: <value>for their own implementations.