Skip to content

feat(tab-bar): add expand and shape props for ionic theme #29888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 25, 2024
Merged

feat(tab-bar): add expand and shape props for ionic theme #29888

merged 17 commits into from
Sep 25, 2024

Conversation

@thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Sep 23, 2024 •
edited
Loading

Issue number: internal

What is the current behavior?

ion-tab-bar does not have the ability to change its border radius. It also can't change the width to fit its contents.

What is the new behavior?

  • Added the shape prop that is only used in the ionic theme.
  • Added tests for shape.
  • Added the expand prop that will determine if the tab bar will fully expand to the screen or only expand to the width of the contents.
  • expand="compact" (expand to the width of the contents) can only be used in the ionic theme.
  • Added tests for expand.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Shape preview
Expand preview

@vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 8:04pm

@github-actions github-actions bot added the package: core @ionic/core package label Sep 23, 2024
@github-actions github-actions bot added the package: angular @ionic/angular package label Sep 23, 2024
@thetaPC thetaPC changed the title refactor(tab-bar): add expand prop for ionic theme refactor(tab-bar): add expand and shape props for ionic theme Sep 24, 2024
@thetaPC thetaPC marked this pull request as ready for review September 24, 2024 20:29
@thetaPC thetaPC requested a review from a team as a code owner September 24, 2024 20:29
@brandyscarney
Copy link
Member

Should this be marked as a feat?

brandyscarney
brandyscarney reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Just a question on the default shape.

@thetaPC thetaPC changed the title refactor(tab-bar): add expand and shape props for ionic theme feat(tab-bar): add expand and shape props for ionic theme Sep 25, 2024
brandyscarney
brandyscarney approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this!

@thetaPC thetaPC merged commit 2af2167 into next Sep 25, 2024
46 checks passed
@thetaPC thetaPC deleted the ROU-11202 branch September 25, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

@OS-giulianasilva OS-giulianasilva OS-giulianasilva approved these changes

@gnbm gnbm Awaiting requested review from gnbm gnbm is a code owner automatically assigned from ionic-team/framework

Assignees

No one assigned

Labels

package: angular @ionic/angular package package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thetaPC @brandyscarney @OS-giulianasilva @Ionitron