-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(ionic): update colors to import function #29891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 15 commits
677e2a2
775329a
6f36e91
b81a8f5
43bd79c
e8fb635
9264083
064c18c
5beef2a
7132b0c
d576a4a
b2a8eee
4a8b90a
ed166e2
21496fb
b8b2889
7a44ac0
35b550b
6c893df
38d00fd
25079c3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With the new changes to Playwright, I realized that the color and font size were not being displayed correctly when using |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,8 +19,10 @@ | |
| --padding-end: #{globals.$ionic-space-400}; | ||
| --padding-bottom: #{globals.$ionic-space-200}; | ||
| --padding-start: #{globals.$ionic-space-400}; | ||
| --color: #{globals.$ionic-color-neutral-1200}; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this color is close to black, the snapshots are going to look very similar. |
||
|
|
||
| font-family: globals.$ionic-font-family; | ||
| font-size: globals.$ionic-font-size-400; | ||
| } | ||
|
|
||
| // Inner Item | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,10 +4,12 @@ | |
|
|
||
| :host { | ||
| --background: transparent; | ||
| --color: #{globals.$ionic-color-neutral-1200}; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this color is close to black, the snapshots are going to look very similar. |
||
|
|
||
| min-height: 58px; | ||
|
|
||
| font-size: globals.$ionic-font-size-350; | ||
| font-weight: globals.$ionic-font-weight-medium; | ||
|
|
||
| line-height: globals.$ionic-line-height-600; | ||
|
|
||
|
|
@@ -35,12 +37,6 @@ | |
| // -------------------------------------------------- | ||
|
|
||
| // Label | ||
| ::slotted(ion-label) { | ||
| --color: #{globals.$ionic-color-neutral-1200}; | ||
|
|
||
| font-weight: globals.$ionic-font-weight-medium; | ||
| } | ||
|
|
||
| ::slotted(ion-label) ::slotted(p) { | ||
| font-weight: globals.$ionic-font-weight-regular; | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,10 @@ | |
| // Ionic Spinner | ||
| // -------------------------------------------------- | ||
|
|
||
| :host { | ||
| --color: #{globals.$ionic-color-neutral-800}; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated this to match Figma else it was trying to re-generate with black being the default value. |
||
| } | ||
|
|
||
| // Sizes | ||
| // -------------------------------------------------- | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,6 +44,7 @@ export const setContent = async (page: Page, html: string, testInfo: TestInfo, o | |
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=1.0" /> | ||
| <link href="${baseUrl}/css/ionic.bundle.css" rel="stylesheet" /> | ||
| ${theme === 'ionic' ? `<link href="${baseUrl}/css/ionic/bundle.ionic.css" rel="stylesheet" />` : ''} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This matches the script that is being used in the test pages. |
||
| <link href="${baseUrl}/scripts/testing/styles.css" rel="stylesheet" /> | ||
| ${palette !== 'light' ? `<link href="${baseUrl}/css/palettes/${palette}.always.css" rel="stylesheet" />` : ''} | ||
| <script src="${baseUrl}/scripts/testing/scripts.js"></script> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After adding the ionic theme file to the
setContent, the snapshots were trying to add more spacing than expected. After investigating, I noticed that this no longer matched Figma.