Skip to content

Conversation

@thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Sep 26, 2024

Issue number: internal


What is the current behavior?

Some of the color mixins were not being correctly imported which caused some styles to display wrong.

The activated button was one of the components that displays the issue.

There are several components that are needing their snapshots to be re-generated. In order to not have a PR with an immense amount of snapshots, several PRs will be created to split off the work to make it easier on reviewers.

What is the new behavior?

  • Snapshots for button have been updated.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Checks will fail because the other snapshots haven't been updated. Once all the PRs are merged into the base branch then checks will pass.

Base branch

@vercel
Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 9:54pm

@github-actions github-actions bot added the package: core @ionic/core package label Sep 26, 2024
@thetaPC thetaPC marked this pull request as ready for review September 27, 2024 19:40
@thetaPC thetaPC requested a review from a team as a code owner September 27, 2024 19:40
@thetaPC thetaPC merged commit 84b49ea into ROU-11149-base Sep 27, 2024
27 of 47 checks passed
@thetaPC thetaPC deleted the ROU-11149-button branch September 27, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants