-
Notifications
You must be signed in to change notification settings - Fork 13.4k
refactor(list-header): update color and font size #29907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
71a2ff9
refactor(item): update color and font size
thetaPC 42904d7
refactor(list-header): update color and font size
thetaPC 668fe1b
refactor(list-header): use typography
thetaPC f69c62e
Merge branch 'ROU-11149-base' of github.com:ionic-team/ionic-framewor…
thetaPC 32b3260
test(list): update snapshots (#29909)
thetaPC 6a7496b
Merge branch 'ROU-11149-base' of github.com:ionic-team/ionic-framewor…
thetaPC 8e7af2c
Merge branch 'ROU-11149-list-header' of github.com:ionic-team/ionic-f…
thetaPC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+789 Bytes
(110%)
....e2e.ts-snapshots/item-disabled-diff-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+793 Bytes
(100%)
...e2e.ts-snapshots/item-disabled-diff-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+585 Bytes
(100%)
....e2e.ts-snapshots/item-disabled-diff-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+11 Bytes
(100%)
...em.e2e.ts-snapshots/item-lines-color-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+195 Bytes
(110%)
...m.e2e.ts-snapshots/item-lines-color-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+9 Bytes
(100%)
...em.e2e.ts-snapshots/item-lines-color-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+8 Bytes
(100%)
...em.e2e.ts-snapshots/item-lines-color-ionic-md-rtl-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+196 Bytes
(110%)
...m.e2e.ts-snapshots/item-lines-color-ionic-md-rtl-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+14 Bytes
(100%)
...em.e2e.ts-snapshots/item-lines-color-ionic-md-rtl-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+11 Bytes
(100%)
...ts-snapshots/item-lines-default-icon-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+195 Bytes
(110%)
...s-snapshots/item-lines-default-icon-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+9 Bytes
(100%)
...ts-snapshots/item-lines-default-icon-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+8 Bytes
(100%)
...ts-snapshots/item-lines-default-icon-ionic-md-rtl-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+196 Bytes
(110%)
...s-snapshots/item-lines-default-icon-ionic-md-rtl-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+14 Bytes
(100%)
...ts-snapshots/item-lines-default-icon-ionic-md-rtl-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2 Bytes
(100%)
....e2e.ts-snapshots/item-lines-default-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-19 Bytes
(99%)
...e2e.ts-snapshots/item-lines-default-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-8 Bytes
(99%)
....e2e.ts-snapshots/item-lines-default-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1 Byte
(100%)
....e2e.ts-snapshots/item-lines-default-ionic-md-rtl-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2 Bytes
(100%)
...e2e.ts-snapshots/item-lines-default-ionic-md-rtl-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-10 Bytes
(99%)
....e2e.ts-snapshots/item-lines-default-ionic-md-rtl-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+11 Bytes
(100%)
...e.ts-snapshots/item-lines-full-color-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+195 Bytes
(110%)
....ts-snapshots/item-lines-full-color-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+9 Bytes
(100%)
...e.ts-snapshots/item-lines-full-color-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+8 Bytes
(100%)
...e.ts-snapshots/item-lines-full-color-ionic-md-rtl-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+196 Bytes
(110%)
....ts-snapshots/item-lines-full-color-ionic-md-rtl-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+14 Bytes
(100%)
...e.ts-snapshots/item-lines-full-color-ionic-md-rtl-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+11 Bytes
(100%)
...2e.ts-snapshots/item-lines-full-icon-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+195 Bytes
(110%)
...e.ts-snapshots/item-lines-full-icon-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+9 Bytes
(100%)
...2e.ts-snapshots/item-lines-full-icon-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+8 Bytes
(100%)
...2e.ts-snapshots/item-lines-full-icon-ionic-md-rtl-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+196 Bytes
(110%)
...e.ts-snapshots/item-lines-full-icon-ionic-md-rtl-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+14 Bytes
(100%)
...2e.ts-snapshots/item-lines-full-icon-ionic-md-rtl-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2 Bytes
(100%)
...tem.e2e.ts-snapshots/item-lines-full-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-19 Bytes
(99%)
...em.e2e.ts-snapshots/item-lines-full-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-8 Bytes
(99%)
...tem.e2e.ts-snapshots/item-lines-full-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1 Byte
(100%)
...tem.e2e.ts-snapshots/item-lines-full-ionic-md-rtl-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+2 Bytes
(100%)
...em.e2e.ts-snapshots/item-lines-full-ionic-md-rtl-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-10 Bytes
(99%)
...tem.e2e.ts-snapshots/item-lines-full-ionic-md-rtl-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+13 Bytes
(100%)
....ts-snapshots/item-lines-inset-color-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+190 Bytes
(110%)
...ts-snapshots/item-lines-inset-color-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+10 Bytes
(100%)
....ts-snapshots/item-lines-inset-color-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+9 Bytes
(100%)
....ts-snapshots/item-lines-inset-color-ionic-md-rtl-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+193 Bytes
(110%)
...ts-snapshots/item-lines-inset-color-ionic-md-rtl-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+12 Bytes
(100%)
....ts-snapshots/item-lines-inset-color-ionic-md-rtl-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+13 Bytes
(100%)
...e.ts-snapshots/item-lines-inset-icon-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+190 Bytes
(110%)
....ts-snapshots/item-lines-inset-icon-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+10 Bytes
(100%)
...e.ts-snapshots/item-lines-inset-icon-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+9 Bytes
(100%)
...e.ts-snapshots/item-lines-inset-icon-ionic-md-rtl-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+193 Bytes
(110%)
....ts-snapshots/item-lines-inset-icon-ionic-md-rtl-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+12 Bytes
(100%)
...e.ts-snapshots/item-lines-inset-icon-ionic-md-rtl-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1 Byte
(100%)
...em.e2e.ts-snapshots/item-lines-inset-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-15 Bytes
(99%)
...m.e2e.ts-snapshots/item-lines-inset-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-9 Bytes
(99%)
...em.e2e.ts-snapshots/item-lines-inset-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-3 Bytes
(100%)
...em.e2e.ts-snapshots/item-lines-inset-ionic-md-rtl-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2 Bytes
(100%)
...m.e2e.ts-snapshots/item-lines-inset-ionic-md-rtl-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-10 Bytes
(99%)
...em.e2e.ts-snapshots/item-lines-inset-ionic-md-rtl-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+19 Bytes
(100%)
...e.ts-snapshots/item-lines-none-color-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+193 Bytes
(110%)
....ts-snapshots/item-lines-none-color-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+48 Bytes
(100%)
...e.ts-snapshots/item-lines-none-color-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+21 Bytes
(100%)
...e.ts-snapshots/item-lines-none-color-ionic-md-rtl-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+195 Bytes
(110%)
....ts-snapshots/item-lines-none-color-ionic-md-rtl-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+42 Bytes
(100%)
...e.ts-snapshots/item-lines-none-color-ionic-md-rtl-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+19 Bytes
(100%)
...2e.ts-snapshots/item-lines-none-icon-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+193 Bytes
(110%)
...e.ts-snapshots/item-lines-none-icon-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+48 Bytes
(100%)
...2e.ts-snapshots/item-lines-none-icon-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+21 Bytes
(100%)
...2e.ts-snapshots/item-lines-none-icon-ionic-md-rtl-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+195 Bytes
(110%)
...e.ts-snapshots/item-lines-none-icon-ionic-md-rtl-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+42 Bytes
(100%)
...2e.ts-snapshots/item-lines-none-icon-ionic-md-rtl-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+0 Bytes
(100%)
...tem.e2e.ts-snapshots/item-lines-none-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-20 Bytes
(99%)
...em.e2e.ts-snapshots/item-lines-none-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-6 Bytes
(99%)
...tem.e2e.ts-snapshots/item-lines-none-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+0 Bytes
(100%)
...tem.e2e.ts-snapshots/item-lines-none-ionic-md-rtl-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+2 Bytes
(100%)
...em.e2e.ts-snapshots/item-lines-none-ionic-md-rtl-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-10 Bytes
(99%)
...tem.e2e.ts-snapshots/item-lines-none-ionic-md-rtl-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+3.18 KB
(110%)
...em.e2e.ts-snapshots/item-states-diff-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+4.23 KB
(110%)
...m.e2e.ts-snapshots/item-states-diff-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+3.85 KB
(110%)
...em.e2e.ts-snapshots/item-states-diff-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+617 Bytes
(100%)
...-header.e2e.ts-snapshots/list-header-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+322 Bytes
(100%)
...header.e2e.ts-snapshots/list-header-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+510 Bytes
(100%)
...-header.e2e.ts-snapshots/list-header-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+629 Bytes
(100%)
...-header.e2e.ts-snapshots/list-header-ionic-md-rtl-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+210 Bytes
(100%)
...header.e2e.ts-snapshots/list-header-ionic-md-rtl-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+544 Bytes
(100%)
...-header.e2e.ts-snapshots/list-header-ionic-md-rtl-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-30 Bytes
(99%)
...e.ts-snapshots/list-header-safe-area-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2 Bytes
(100%)
....ts-snapshots/list-header-safe-area-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-12 Bytes
(99%)
...e.ts-snapshots/list-header-safe-area-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-29 Bytes
(99%)
...e.ts-snapshots/list-header-safe-area-ionic-md-rtl-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1 Byte
(100%)
....ts-snapshots/list-header-safe-area-ionic-md-rtl-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-12 Bytes
(99%)
...e.ts-snapshots/list-header-safe-area-ionic-md-rtl-light-Mobile-Safari-linux.png
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.