fix(textarea): update background placement for ionic #29910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
changed the title
thetaPC
requested review from
JoaoFerreira-FrontEnd,
brandyscarney and
joselrio
...l/textarea.e2e.ts-snapshots/textarea-fill-outline-ionic-md-ltr-light-Mobile-Chrome-linux.png
Show resolved
Hide resolved
....ts-snapshots/textarea-fill-shaped-outline-custom-ionic-md-rtl-light-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
...rea.e2e.ts-snapshots/textarea-fill-shaped-outline-ionic-md-ltr-light-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Do we need these rtl tests for the solid shape?
There was a problem hiding this comment.
I ended up removing rtl for all the fills since the point of these tests are the fills: fcd9937
brandyscarney
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
The background is not set to the correct element when the textarea has a fill of outline.
What is the new behavior?
Does this introduce a breaking change?
Other information
Preview