- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.4k
 
feat(toast): add the default styles for ionic theme #29922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           The latest updates on your projects. Learn more about Vercel for Git ↗︎ 
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think I found one discrepancy with the designs. If there is an icon the left (in LTR mode, before the text) the distance between the icon and text should be 8px but right now it's 16px. Otherwise, looks good!
Issue number: internal
What is the current behavior?
Toast does not have the
ionictheme styles.What is the new behavior?
ionicdefault styles for toastDoes this introduce a breaking change?
Other information
Preview