Skip to content

Conversation

@thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Oct 2, 2024

Issue number: internal


What is the current behavior?

Toast does not have the ionic theme styles.

What is the new behavior?

  • Added ionic default styles for toast
  • Added snapshots

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

@vercel
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 6:47pm

@github-actions github-actions bot added the package: core @ionic/core package label Oct 2, 2024
@thetaPC thetaPC marked this pull request as ready for review October 2, 2024 23:58
@thetaPC thetaPC requested a review from a team as a code owner October 2, 2024 23:58
@thetaPC thetaPC requested a review from brandyscarney October 2, 2024 23:58
@thetaPC thetaPC requested a review from tanner-reits October 4, 2024 15:15
Copy link
Contributor

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think I found one discrepancy with the designs. If there is an icon the left (in LTR mode, before the text) the distance between the icon and text should be 8px but right now it's 16px. Otherwise, looks good!

@thetaPC thetaPC merged commit c295a08 into next Oct 4, 2024
46 checks passed
@thetaPC thetaPC deleted the ROU-11198 branch October 4, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants