Skip to content

test(styles): update button styles for test pages #29931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2024
Merged

test(styles): update button styles for test pages #29931

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d208e9
test(styles): update button styles for test pages
thetaPC Oct 10, 2024
4e8ec56
test(popover): update size test page
thetaPC Oct 11, 2024
d2f6362
test(styles): update comments
thetaPC Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions core/scripts/testing/styles.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 9 additions & 5 deletions core/src/components/popover/test/size/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
ion-app > ion-content {
--background: #dddddd;
}
ion-content button {
ion-content button.trigger {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was needed to override the padding from styles.css.

padding: 12px 16px;
}
.grid {
Expand Down Expand Up @@ -57,26 +57,30 @@
<div class="grid">
<div class="grid-item">
<h2>Cover</h2>
<button id="cover-trigger">Trigger</button>
<button id="cover-trigger" class="trigger">Trigger</button>
<ion-popover show-backdrop="false" class="cover-popover" trigger="cover-trigger" size="cover">
<ion-content class="ion-padding"> My really really really really long content </ion-content>
</ion-popover>
</div>
<div class="grid-item">
<h2>With Event</h2>
<button id="event-trigger" onclick="openPopover('event-popover', event, 'false')">Trigger</button>
<button id="event-trigger" class="trigger" onclick="openPopover('event-popover', event, 'false')">
Trigger
</button>
</div>

<div class="grid-item">
<h2>Auto</h2>
<button id="auto-trigger">Trigger</button>
<button id="auto-trigger" class="trigger">Trigger</button>
<ion-popover show-backdrop="false" class="auto-popover" trigger="auto-trigger">
<ion-content class="ion-padding"> My really really really really long content </ion-content>
</ion-popover>
</div>
<div class="grid-item">
<h2>No Event</h2>
<button id="no-event-trigger" onclick="openPopover('no-event-popover', null, 'true')">Trigger</button>
<button id="no-event-trigger" class="trigger" onclick="openPopover('no-event-popover', null, 'true')">
Trigger
</button>
</div>
</div>
</ion-content>
Expand Down
Loading