Skip to content

feat(accordion): add default styles for ionic theme #29933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Oct 16, 2024
Merged

feat(accordion): add default styles for ionic theme #29933

merged 33 commits into from
Oct 16, 2024

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Oct 11, 2024 •
edited
Loading

Issue number: internal

What is the current behavior?

The Accordion uses the Material Design styles for the Ionic theme.

What is the new behavior?

  • Updates Accordion to use the Ionic theme styles defined in Figma
  • Adds an e2e test to the basic test to check for text content in the content slot
  • Adds the ionic theme to the multiple e2e test
  • Adds an e2e test for states which screenshots disabled, activated & focused
  • Updates Item to accommodate the Accordion styles
  • Updates the global core scss file to override the Toggle Icon and Items in an Accordion

Does this introduce a breaking change?

  • Yes
  • No

Other information

This includes the changes on #29938, so that needs to be merged first.

@vercel
Copy link

vercel bot commented Oct 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 4:04pm

@github-actions github-actions bot added the package: core @ionic/core package label Oct 11, 2024
@brandyscarney brandyscarney mentioned this pull request Oct 14, 2024
Merged
2 tasks
@brandyscarney brandyscarney changed the base branch from next to ROU-11258 October 14, 2024 23:25
@brandyscarney brandyscarney marked this pull request as ready for review October 15, 2024 16:38
@brandyscarney brandyscarney requested a review from a team as a code owner October 15, 2024 16:38
@brandyscarney brandyscarney requested review from rugoncalves and removed request for a team October 15, 2024 16:38
BenOsodrac
BenOsodrac approved these changes Oct 16, 2024
View reviewed changes
tanner-reits
tanner-reits approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from ROU-11258 to next October 16, 2024 15:56
@brandyscarney brandyscarney merged commit 5d4a989 into next Oct 16, 2024
47 checks passed
@brandyscarney brandyscarney deleted the ROU-11257 branch October 16, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenOsodrac BenOsodrac BenOsodrac approved these changes

@rugoncalves rugoncalves Awaiting requested review from rugoncalves rugoncalves is a code owner automatically assigned from ionic-team/framework

+1 more reviewer

@tanner-reits tanner-reits tanner-reits approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brandyscarney @BenOsodrac @tanner-reits