Skip to content

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Oct 14, 2024

Issue number: internal


What is the current behavior?

The Accordion Group uses the Material Design styles for the Ionic theme.

What is the new behavior?

Adds the following:

  • An ionic theme file with styles for the Accordion Group
  • An e2e test for the expand property with screenshots of the default (compact) expand and "inset"
  • An e2e test for states with screenshots of a disabled Accordion Group

Does this introduce a breaking change?

  • Yes
  • No

Other information

The styles for the Accordion are on #29933.

@vercel
Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 3:27pm

@brandyscarney brandyscarney marked this pull request as ready for review October 15, 2024 16:14
@brandyscarney brandyscarney requested a review from a team as a code owner October 15, 2024 16:14
@brandyscarney brandyscarney requested a review from thetaPC October 15, 2024 16:14
Copy link
Contributor

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@brandyscarney brandyscarney merged commit f4766c6 into next Oct 16, 2024
46 checks passed
@brandyscarney brandyscarney deleted the ROU-11258 branch October 16, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants