Skip to content

Conversation

@OS-pedrolourenco
Copy link
Contributor

Issue number: internal


What is the current behavior?

This PR aims to fix an issue introduced in #29932 where the enter animation for ionic theme was in a broken state when the modal's initial breakpoint value was lesser than the specified backdrop breakpoint.

What is the new behavior?

  • The erroneous behaviour happened because the shouldShowBackdrop constant had a false value which was being taken into consideration when computing the backdrop opacity for the ionic theme. This PR fixes this by always transitioning the backdrop opacity from 0 to 0.7 once the modal appears, independently of the initial, current or activation breakpoint.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@OS-pedrolourenco OS-pedrolourenco requested a review from a team as a code owner October 21, 2024 16:46
@vercel
Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 1:54pm

@github-actions github-actions bot added the package: core @ionic/core package label Oct 21, 2024
@tanner-reits tanner-reits changed the title feat(modal): fix enter animation when the initial breakpoint value is lesser than the backdrop breakpoint fix(modal): fix enter animation when the initial breakpoint value is less than the backdrop breakpoint Oct 21, 2024
Copy link
Contributor

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the fix and update the PR title.

Only small feedback would be to add a comment to the backdropBreakpoint prop on the modal calling out that it is ignored for the ionic theme.

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OS-pedrolourenco OS-pedrolourenco merged commit bdb7cd6 into next Oct 22, 2024
46 checks passed
@OS-pedrolourenco OS-pedrolourenco deleted the ROU-11247-v2 branch October 22, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants