Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
7e0dd91
First commit
OS-pedrolourenco Oct 29, 2024
4b36e73
Finishing range styling
OS-pedrolourenco Oct 30, 2024
c65e3c9
Fixing lint issue
OS-pedrolourenco Oct 30, 2024
06408d8
CR
OS-pedrolourenco Oct 30, 2024
3152425
Merge branch 'next' into ROU-11323
OS-pedrolourenco Oct 30, 2024
6004d45
CR + QA
OS-pedrolourenco Oct 31, 2024
4db25bf
Fixing lint issue
OS-pedrolourenco Oct 31, 2024
5300f3b
Merge branch 'next' into ROU-11323
OS-pedrolourenco Oct 31, 2024
2ada43c
Updating the range pin to always be visible when enabled for the ioni…
OS-pedrolourenco Oct 31, 2024
e55f83d
CR
OS-pedrolourenco Oct 31, 2024
c2aede0
Merge branch 'next' into ROU-11323
OS-pedrolourenco Oct 31, 2024
1129d9a
Merge branch 'ROU-11323' into ROU-11324
OS-pedrolourenco Oct 31, 2024
f27239a
Fixing one css issue caused by previous CR
OS-pedrolourenco Oct 31, 2024
1a9493b
Fixing snapshot tests
OS-pedrolourenco Oct 31, 2024
b543e1f
Merge branch 'next' into ROU-11323
OS-pedrolourenco Oct 31, 2024
db3239a
Removing unnecessary import
OS-pedrolourenco Oct 31, 2024
d602f02
Merge branch 'ROU-11323' into ROU-11324
OS-pedrolourenco Oct 31, 2024
e3423a0
Fixing lint issues
OS-pedrolourenco Oct 31, 2024
00541de
Fixing build issue
OS-pedrolourenco Oct 31, 2024
7918734
Updating snapshot tests
OS-pedrolourenco Oct 31, 2024
a74024a
CR
OS-pedrolourenco Nov 4, 2024
eb17aa4
Merge branch 'next' into ROU-11323
OS-pedrolourenco Nov 4, 2024
bc373d5
Merge branch 'ROU-11323' into ROU-11324
OS-pedrolourenco Nov 4, 2024
69c327c
CR
OS-pedrolourenco Nov 4, 2024
10f6745
Fix broken snapshot tests
OS-pedrolourenco Nov 4, 2024
b0586fd
Merge branch 'ROU-11323' into ROU-11324
OS-pedrolourenco Nov 4, 2024
e82a68a
Fix broken snapshot tests
OS-pedrolourenco Nov 4, 2024
a6c3b8d
Fix lint issue
OS-pedrolourenco Nov 4, 2024
44b8f4b
Merge branch 'next' into ROU-11323
OS-pedrolourenco Nov 5, 2024
c033d7c
Merge branch 'refs/heads/ROU-11323' into ROU-11324
OS-pedrolourenco Nov 5, 2024
80cada6
CR - Revert percentage injection for ionic theme
OS-pedrolourenco Nov 5, 2024
e3363cf
Updating snapshot tests
OS-pedrolourenco Nov 5, 2024
9c31e5e
Merge branch 'next' into ROU-11324
OS-pedrolourenco Nov 5, 2024
a25504e
Fix lint issue
OS-pedrolourenco Nov 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions core/src/components/range/range.ionic.scss
Copy link
Member

@brandyscarney brandyscarney Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 66 should be:

@include padding(calc(globals.$ion-space-100 + globals.$ion-scale-600), null, null, null);

This will make it so the padding top is the height of the pin text + the space between the knob and pin text

Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
* overlapping the range. The buffer is added to the
* bottom of the range label instead of the host.
*/
@include padding(calc(globals.$ion-space-200 + globals.dynamic-font(12px)), null, null, null);
@include padding(calc(globals.$ion-space-100 + globals.$ion-scale-600), null, null, null);
}

:host(.range-has-pin.range-label-placement-stacked) .label-text-wrapper {
Expand Down Expand Up @@ -107,12 +107,11 @@
}

.range-pin {
@include transform(translate3d(0, 100%, 0), scale(0.01));
@include padding(globals.$ion-space-200, globals.$ion-space-200, globals.$ion-space-200, globals.$ion-space-200);
@include padding(null, null, globals.$ion-space-100, null);

min-width: globals.$ion-scale-700;

transition: transform 120ms ease;
transform: translate3d(0, calc(-100%), 0);

background: transparent;

Expand All @@ -128,20 +127,6 @@
box-sizing: border-box;
}

/**
* The -100% ensures the pin sits on top
* of the range-knob-handle container.
* We apply 11px so that the pin
* text is closer to the knob inside of the container.
* We also apply the 11px here instead of using "top"
* otherwise the pin text will translate below the knob
* when the text is scaled.
*/
.range-knob-pressed .range-pin,
.range-knob-handle.ion-focused .range-pin {
transform: translate3d(0, calc(-100% + 11px), 0) scale(1);
}

// Ionic Range: Disabled (based on iOS Range)
// --------------------------------------------------
// When the range is disabled, the entire range,
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading