-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(range): updating the range pin to always be visible when enabled for ionic theme #29988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
7e0dd91
First commit
OS-pedrolourenco 4b36e73
Finishing range styling
OS-pedrolourenco c65e3c9
Fixing lint issue
OS-pedrolourenco 06408d8
CR
OS-pedrolourenco 3152425
Merge branch 'next' into ROU-11323
OS-pedrolourenco 6004d45
CR + QA
OS-pedrolourenco 4db25bf
Fixing lint issue
OS-pedrolourenco 5300f3b
Merge branch 'next' into ROU-11323
OS-pedrolourenco 2ada43c
Updating the range pin to always be visible when enabled for the ioni…
OS-pedrolourenco e55f83d
CR
OS-pedrolourenco c2aede0
Merge branch 'next' into ROU-11323
OS-pedrolourenco 1129d9a
Merge branch 'ROU-11323' into ROU-11324
OS-pedrolourenco f27239a
Fixing one css issue caused by previous CR
OS-pedrolourenco 1a9493b
Fixing snapshot tests
OS-pedrolourenco b543e1f
Merge branch 'next' into ROU-11323
OS-pedrolourenco db3239a
Removing unnecessary import
OS-pedrolourenco d602f02
Merge branch 'ROU-11323' into ROU-11324
OS-pedrolourenco e3423a0
Fixing lint issues
OS-pedrolourenco 00541de
Fixing build issue
OS-pedrolourenco 7918734
Updating snapshot tests
OS-pedrolourenco a74024a
CR
OS-pedrolourenco eb17aa4
Merge branch 'next' into ROU-11323
OS-pedrolourenco bc373d5
Merge branch 'ROU-11323' into ROU-11324
OS-pedrolourenco 69c327c
CR
OS-pedrolourenco 10f6745
Fix broken snapshot tests
OS-pedrolourenco b0586fd
Merge branch 'ROU-11323' into ROU-11324
OS-pedrolourenco e82a68a
Fix broken snapshot tests
OS-pedrolourenco a6c3b8d
Fix lint issue
OS-pedrolourenco 44b8f4b
Merge branch 'next' into ROU-11323
OS-pedrolourenco c033d7c
Merge branch 'refs/heads/ROU-11323' into ROU-11324
OS-pedrolourenco 80cada6
CR - Revert percentage injection for ionic theme
OS-pedrolourenco e3363cf
Updating snapshot tests
OS-pedrolourenco 9c31e5e
Merge branch 'next' into ROU-11324
OS-pedrolourenco a25504e
Fix lint issue
OS-pedrolourenco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+38 Bytes
(100%)
...sic/range.e2e.ts-snapshots/range-pin-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+102 Bytes
(100%)
...ic/range.e2e.ts-snapshots/range-pin-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+36 Bytes
(100%)
...sic/range.e2e.ts-snapshots/range-pin-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 66 should be:
This will make it so the padding top is the height of the pin text + the space between the knob and pin text