Skip to content

Conversation

@thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Nov 22, 2024

Issue number: internal


What is the current behavior?

When the menu is presented on an Android device, TalkBack's focus rings may appear in the wrong position due to the transition (specifically transform styles). This occurs because the focus rings are initially displayed at the starting position of the elements before the transition begins.

What is the new behavior?

  • When an overlay is being animated (presenting or dismissing), the overlay will hide from screen readers. This allows Talkback to display the focus rings on the correct position.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 8.4.1-dev.11732305980.19d90e1c

Related to #29951

@vercel
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 11:58pm

@github-actions github-actions bot added the package: core @ionic/core package label Nov 22, 2024
@thetaPC thetaPC marked this pull request as ready for review November 23, 2024 00:08
@thetaPC thetaPC requested a review from a team as a code owner November 23, 2024 00:08
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thetaPC thetaPC added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 845071c Nov 27, 2024
105 checks passed
@thetaPC thetaPC deleted the ROU-10994 branch November 27, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants