-
Notifications
You must be signed in to change notification settings - Fork 13.4k
test(angular): add ng19 test app #30041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5cde83b
test(angular): add ng19 test app
brandyscarney 4adbc8e
chore(angular): add test app to CI workflows
brandyscarney 53e2dca
docs(angular): add missing step for running a test app
brandyscarney 5b8ab33
add back polyfills
brandyscarney ca62104
server fixes
brandyscarney 4725dfc
test(angular): lint
brandyscarney 33396fd
test(angular): update angular config
brandyscarney 0e9f3b9
test(angular): config changes
brandyscarney 47b69c9
test(angular): move common e2e flies
brandyscarney 87b4d1b
test(angular): update version test
brandyscarney 655cbdd
test(angular): remove and update duplicated test files
brandyscarney 8b31ce5
test(angular): lint
brandyscarney 6aacb4a
test(angular): move duplicate files
brandyscarney 803515f
test(angular): update app module
brandyscarney ed76218
test(angular): add back standalone true for backwards compat
brandyscarney a34e5c0
docs(angular): clarify process for adding new test app
brandyscarney c002219
test(angular): update so all versions pass lint
brandyscarney c6167c4
test(angular): only update the OnInit changes
brandyscarney f9b18fa
test(angular): update ng19 for ssr
brandyscarney 30379cf
test(angular): update eslint to latest
brandyscarney 668d00a
test(angular): ignore prefer standalone
brandyscarney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 0 additions & 8 deletions
8
packages/angular/test/apps/ng17/e2e/src/lazy/bind-component-inputs.spec.ts
This file was deleted.
Oops, something went wrong.
20 changes: 0 additions & 20 deletions
20
packages/angular/test/apps/ng17/e2e/src/lazy/modal-nav-params.spec.ts
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
packages/angular/test/apps/ng18/e2e/src/lazy/bind-component-inputs.spec.ts
This file was deleted.
Oops, something went wrong.
20 changes: 0 additions & 20 deletions
20
packages/angular/test/apps/ng18/e2e/src/lazy/modal-nav-params.spec.ts
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| { | ||
| "$schema": "./node_modules/@angular/cli/lib/config/schema.json", | ||
| "version": 1, | ||
| "newProjectRoot": "projects", | ||
| "projects": { | ||
| "test-app": { | ||
| "root": "", | ||
| "sourceRoot": "src", | ||
| "projectType": "application", | ||
| "prefix": "app", | ||
| "schematics": {}, | ||
| "architect": { | ||
| "build": { | ||
| "builder": "@angular-devkit/build-angular:browser", | ||
| "options": { | ||
| "outputPath": "dist/test-app", | ||
| "index": "src/index.html", | ||
| "main": "src/main.ts", | ||
| "polyfills": ["src/polyfills.ts"], | ||
| "tsConfig": "tsconfig.app.json", | ||
| "assets": [ | ||
| "src/favicon.ico", | ||
| { | ||
| "glob": "**/*", | ||
| "input": "src/assets", | ||
| "output": "assets" | ||
| }, | ||
| { | ||
| "glob": "**/*.svg", | ||
| "input": "node_modules/ionicons/dist/ionicons/svg", | ||
| "output": "./svg" | ||
| } | ||
| ], | ||
| "styles": ["src/styles.css"], | ||
| "scripts": [] | ||
| }, | ||
| "configurations": { | ||
| "production": { | ||
| "fileReplacements": [ | ||
| { | ||
| "replace": "src/environments/environment.ts", | ||
| "with": "src/environments/environment.prod.ts" | ||
| } | ||
| ], | ||
| "optimization": true, | ||
| "outputHashing": "all", | ||
| "sourceMap": false, | ||
| "namedChunks": false, | ||
| "aot": true, | ||
| "progress": false, | ||
| "extractLicenses": true, | ||
| "budgets": [ | ||
| { | ||
| "type": "initial", | ||
| "maximumWarning": "2mb", | ||
| "maximumError": "5mb" | ||
| }, | ||
| { | ||
| "type": "anyComponentStyle", | ||
| "maximumWarning": "6kb" | ||
| } | ||
| ] | ||
| }, | ||
| "development": { | ||
| "optimization": false, | ||
| "extractLicenses": false, | ||
| "sourceMap": true, | ||
| "namedChunks": true | ||
| } | ||
| }, | ||
| "defaultConfiguration": "production" | ||
| }, | ||
| "server": { | ||
| "builder": "@angular-devkit/build-angular:server", | ||
| "options": { | ||
| "outputPath": "dist/test-app-server", | ||
| "main": "src/main.server.ts", | ||
| "tsConfig": "tsconfig.server.json" | ||
| }, | ||
| "configurations": { | ||
| "production": { | ||
| "fileReplacements": [ | ||
| { | ||
| "replace": "src/environments/environment.ts", | ||
| "with": "src/environments/environment.prod.ts" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "serve": { | ||
| "builder": "@angular-devkit/build-angular:dev-server", | ||
| "options": { | ||
| "buildTarget": "test-app:build" | ||
| }, | ||
| "configurations": { | ||
| "production": { | ||
| "buildTarget": "test-app:build:production" | ||
| }, | ||
| "development": { | ||
| "buildTarget": "test-app:build:development" | ||
| } | ||
| }, | ||
| "defaultConfiguration": "development" | ||
| }, | ||
| "prerender": { | ||
| "builder": "@nguniversal/builders:prerender", | ||
| "options": { | ||
| "buildTarget": "test-app:build:production", | ||
| "serverTarget": "test-app:server:production", | ||
| "routes": ["/"] | ||
| } | ||
| }, | ||
| "extract-i18n": { | ||
| "builder": "@angular-devkit/build-angular:extract-i18n", | ||
| "options": { | ||
| "buildTarget": "test-app:build" | ||
| } | ||
| }, | ||
| "lint": { | ||
| "builder": "@angular-eslint/builder:lint", | ||
| "options": { | ||
| "lintFilePatterns": [ | ||
| "src/**/*.ts", | ||
| "src/**/*.html" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "cli": { | ||
| "schematicCollections": ["@angular-eslint/schematics"], | ||
| "cache": { | ||
| "enabled": false | ||
| }, | ||
| "analytics": false | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { defineConfig } from 'cypress' | ||
|
|
||
| export default defineConfig({ | ||
| video: false, | ||
| screenshotOnRunFailure: false, | ||
| e2e: { | ||
| // We've imported your old cypress plugins here. | ||
| // You may want to clean this up later by importing these. | ||
| setupNodeEvents(on, config) { | ||
| return require('./cypress/plugins/index.js')(on, config) | ||
| }, | ||
| specPattern: './e2e/**/*.spec.ts', | ||
| baseUrl: 'http://localhost:4200/', | ||
| excludeSpecPattern: '**/examples/*', | ||
| }, | ||
| }) |
Empty file.
5 changes: 5 additions & 0 deletions
5
packages/angular/test/apps/ng19/e2e/src/lazy/angular-version.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| it("should be on Angular 19", () => { | ||
| cy.visit('/lazy'); | ||
|
|
||
| cy.get('ion-title').contains('Angular 19'); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "extends": "../tsconfig.json", | ||
| "compilerOptions": { | ||
| "outDir": "../out-tsc/e2e", | ||
| "module": "commonjs", | ||
| "target": "es5", | ||
| "types": ["cypress", "node"] | ||
| }, | ||
| "include": [ | ||
| "../cypress/**/*.ts", | ||
| "../cypress/support/**/*.ts" | ||
| ] | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files were moved to
base/as they are all the same between versions