Skip to content

feat(select): add focus on tab #30076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Dec 17, 2024
Merged

feat(select): add focus on tab #30076

merged 25 commits into from
Dec 17, 2024

Conversation

@BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented Dec 11, 2024 •
edited
Loading

Issue number: internal

What is the new behavior?

  • Added focus styles on tab for the ion-select, using the --highlight variable.
  • Adjusted highlight tests to work for ionic as well, just for the outline type.
  • Fixed select border-color token used and updated snapshots (this affected all ionic theme snapshots for select). Although not directly related to focus task, the incorrect color was making it very hard to see the differences between the focus colors.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@BenOsodrac BenOsodrac added type: feature request a new feature, enhancement, or improvement package: core @ionic/core package labels Dec 11, 2024
@vercel
Copy link

vercel bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 7:43pm

@BenOsodrac BenOsodrac marked this pull request as ready for review December 11, 2024 11:30
@BenOsodrac BenOsodrac requested a review from a team as a code owner December 11, 2024 11:31
@BenOsodrac BenOsodrac requested review from brandyscarney and gnbm and removed request for gnbm December 11, 2024 11:31
brandyscarney
brandyscarney approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add tests for this?

@BenOsodrac
Copy link
Contributor Author

BenOsodrac commented Dec 12, 2024

Should we add tests for this?

Yes, good point, just added them :)

thetaPC
thetaPC requested changes Dec 12, 2024
View reviewed changes
@BenOsodrac BenOsodrac requested a review from thetaPC December 12, 2024 20:27
thetaPC
thetaPC requested changes Dec 13, 2024
View reviewed changes
@BenOsodrac BenOsodrac requested a review from thetaPC December 16, 2024 10:01
thetaPC
thetaPC requested changes Dec 16, 2024
View reviewed changes
@BenOsodrac BenOsodrac requested a review from thetaPC December 16, 2024 19:53
thetaPC
thetaPC approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenOsodrac BenOsodrac merged commit b7da1e8 into next Dec 17, 2024
46 checks passed
@BenOsodrac BenOsodrac deleted the ROU-11445-select branch December 17, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

@thetaPC thetaPC thetaPC approved these changes

Assignees

No one assigned

Labels

package: core @ionic/core package type: feature request a new feature, enhancement, or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BenOsodrac @brandyscarney @thetaPC @Ionitron