Skip to content

Conversation

@BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented Dec 11, 2024

Issue number: internal


What is the new behavior?

  • Added focus styles on tab for the ion-select, using the --highlight variable.
  • Adjusted highlight tests to work for ionic as well, just for the outline type.
  • Fixed select border-color token used and updated snapshots (this affected all ionic theme snapshots for select). Although not directly related to focus task, the incorrect color was making it very hard to see the differences between the focus colors.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@BenOsodrac BenOsodrac added type: feature request a new feature, enhancement, or improvement package: core @ionic/core package labels Dec 11, 2024
@vercel
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 7:43pm

@BenOsodrac BenOsodrac marked this pull request as ready for review December 11, 2024 11:30
@BenOsodrac BenOsodrac requested a review from a team as a code owner December 11, 2024 11:31
@BenOsodrac BenOsodrac requested review from brandyscarney and gnbm and removed request for gnbm December 11, 2024 11:31
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add tests for this?

@BenOsodrac
Copy link
Contributor Author

Should we add tests for this?

Yes, good point, just added them :)

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenOsodrac BenOsodrac merged commit b7da1e8 into next Dec 17, 2024
46 checks passed
@BenOsodrac BenOsodrac deleted the ROU-11445-select branch December 17, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package type: feature request a new feature, enhancement, or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants