Skip to content

fix(select): ensure select sizes are respected when the label is empty #30087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 20, 2024
Merged

fix(select): ensure select sizes are respected when the label is empty #30087

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6e58dbd
- When select is used with ioni-theme, the select should respect the …
JoaoFerreira-FrontEnd Dec 16, 2024
60cd0fd
- rollback changes on select.ionic;
JoaoFerreira-FrontEnd Dec 17, 2024
c7c270a
Merge branch 'next' into ROU-11438
JoaoFerreira-FrontEnd Dec 17, 2024
86903ee
- update select size test page;
JoaoFerreira-FrontEnd Dec 19, 2024
7a3f3b5
Merge branch 'ROU-11438' of https://github.com/ionic-team/ionic-frame…
JoaoFerreira-FrontEnd Dec 19, 2024
41d04f4
- add test for empty label select;
JoaoFerreira-FrontEnd Dec 19, 2024
69d5425
fix(select): checkout correct snapshots
thetaPC Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/components/select/select.ionic.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@
width: 100%;
}

:host(.select-label-placement-stacked) .select-wrapper-inner{
flex-grow: 0;
}

// Select Native Wrapper
// ----------------------------------------------------------------

Expand Down
Loading