fix(segment-button): protect connectedCallback for when segment-content has not yet been created #30133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…has not yet been created
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
christian-bromann
left a comment
christian-bromann
left a comment
There was a problem hiding this comment.
Some minor comments
| let animationFrameId: number; | ||
|
|
||
| const check = () => { | ||
| const segmentView = this.getNextSiblingOfType<HTMLIonSegmentViewElement>(ionSegment!); // Skip the text nodes |
Contributor
There was a problem hiding this comment.
How about moving the if (!ionSegment) { into the check method instead so we can avoid using !?
| reject(new Error(`Segment not found when looking for Segment Content`)); | ||
| } | ||
|
|
||
| let timeoutId: any = null; |
Contributor
There was a problem hiding this comment.
let's properly type this
Suggested change
| let timeoutId: any = null; | |
| let timeoutId: number | undefined = undefined; |
OS-pedrolourenco
added a commit
that referenced
this pull request
Jan 17, 2025
…nt has not yet been created (#30133) Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When the `connectedCallback` method is called for a segment-button and its corresponding segment-content has not been created in that instant, a console error is thrown and the method returns. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - `connectedCallback` will now wait, at most 1 second, for the corresponding segment-content to be created. - The new behaviour can be tested in segment-view/basic. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
When the
connectedCallbackmethod is called for a segment-button and its corresponding segment-content has not been created in that instant, a console error is thrown and the method returns.What is the new behavior?
connectedCallbackwill now wait, at most 1 second, for the corresponding segment-content to be created.Does this introduce a breaking change?
Other information