- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.4k
 
feat(select): add helperText and errorText properties #30143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            19 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      5acf8ab
              
                feat(select): add helperText and errorText properties
              
              
                brandyscarney d147f89
              
                test(select): add e2e test for bottom content
              
              
                brandyscarney 51e7920
              
                chore(): add updated snapshots
              
              
                brandyscarney e84c783
              
                chore: api
              
              
                brandyscarney c610a03
              
                line break
              
              
                brandyscarney 4c648d3
              
                feat(select): add css vars for color, screenshot tests and updated sn…
              
              
                brandyscarney 0c0082c
              
                style: build and lint
              
              
                brandyscarney 72e9135
              
                refactor(select): remove added css vars in favor of parts
              
              
                brandyscarney b2695f6
              
                test(e2e): update e2e test for parts
              
              
                brandyscarney fc8412f
              
                chore(): add updated snapshots
              
              
                brandyscarney f6da04d
              
                style: lint
              
              
                brandyscarney 66d6b07
              
                test(select): hide toggle fill button on ios
              
              
                brandyscarney eee3c8b
              
                Merge branch 'feature-8.5' into ROU-11551
              
              
                brandyscarney 62d23fb
              
                Merge branch 'feature-8.5' into ROU-11551
              
              
                brandyscarney 6c72476
              
                Merge branch 'feature-8.5' into ROU-11551
              
              
                brandyscarney 9d896b3
              
                Merge branch 'feature-8.5' into ROU-11551
              
              
                brandyscarney e8e1c3f
              
                fix(angular): add missing props
              
              
                brandyscarney 12b567a
              
                Merge branch 'feature-8.5' into ROU-11551
              
              
                brandyscarney 4da8510
              
                Merge branch 'feature-8.5' into ROU-11551
              
              
                brandyscarney File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the
supporting-textpart so users could change them at the same time using:but if we think it should only be the one part they could write this without it:
I am copying Material Design 2 and Material Design 3 naming here, but let me know if there are other ideas.