Skip to content

Conversation

@OS-giulianasilva
Copy link
Contributor

@OS-giulianasilva OS-giulianasilva commented Jan 24, 2025

Issue number: resolves internal


What is the current behavior?

  • Currently, the screen reader do not announce the component as required when required={true}.

What is the new behavior?

  • Added a new required prop to be used for accessibility purposes that adds the required attribute to toggle's inner native input.

Does this introduce a breaking change?

  • Yes
  • No

@OS-giulianasilva OS-giulianasilva requested a review from a team as a code owner January 24, 2025 12:28
@OS-giulianasilva OS-giulianasilva requested a review from gnbm January 24, 2025 12:28
@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package package: vue @ionic/vue package labels Jan 24, 2025
@vercel
Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 9:42am

@OS-giulianasilva OS-giulianasilva changed the base branch from main to feature-8.5 January 24, 2025 18:08
@gnbm gnbm self-requested a review February 3, 2025 12:25
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with VoiceOver

@OS-giulianasilva OS-giulianasilva merged commit 0bbb9f3 into feature-8.5 Feb 4, 2025
47 checks passed
@OS-giulianasilva OS-giulianasilva deleted the ROU-11112-toggle branch February 4, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants