-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(progress-bar): add styling for the ionic theme #30185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in other PRs, code needs to be reviewed after being copying and pasting and updated appropriately.
core/src/components/progress-bar/test/shape/progress-bar.e2e.ts
Outdated
Show resolved
Hide resolved
core/src/components/progress-bar/test/shape/progress-bar.e2e.ts
Outdated
Show resolved
Hide resolved
...r.e2e.ts-snapshots/progress-bar-shape-rectangular-ionic-md-rtl-light-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
...ess-bar.e2e.ts-snapshots/progress-bar-shape-round-ionic-md-rtl-light-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
thetaPC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we need to have a snapshot for basic. Make sure to update progress-bar/test/basic/progress-bar.e2e.ts to include ionic-md
- configs().forEach(({ title, screenshot, config }) => {
+ configs({ modes: ['ios', 'md', 'ionic-md'] }).forEach(({ title, screenshot, config }) => {There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete the shape snapshots and re-generate them. Playwright isn't able to detect the background change to buffer. That's why we need to force a re-generation. Background shouldn't be white, but neutral 100.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have regenerated the screenshots but no changes were made in the regeneration. I think the bar background looks white in comparison with #ccc7c7 colour we set to the container background, which is more gray-ish, but in reality it's not white.
thetaPC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thetaPC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue number: internal
What is the current behavior?
ion-progress-bar does not currently have any custom styling for the ionic theme.
What is the new behavior?
According to the design, the following styling changes were made:
Does this introduce a breaking change?
Other information