Skip to content

fix(select): scroll to the selected option before the overlay is visible #30214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 27, 2025
Merged

fix(select): scroll to the selected option before the overlay is visible #30214

merged 5 commits into from
Feb 27, 2025

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Feb 25, 2025 •
edited
Loading

@vercel
Copy link

vercel bot commented Feb 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 4:56pm

@github-actions github-actions bot added the package: core @ionic/core package label Feb 25, 2025
BenOsodrac
BenOsodrac approved these changes Feb 26, 2025
View reviewed changes
@brandyscarney brandyscarney marked this pull request as ready for review February 26, 2025 15:29
@brandyscarney brandyscarney requested a review from a team as a code owner February 26, 2025 15:29
@brandyscarney brandyscarney requested review from thetaPC and removed request for a team February 26, 2025 15:29
thetaPC
thetaPC approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!! Just a tiny suggestion but not a blocker.

thetaPC
thetaPC approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

thetaPC
thetaPC approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney brandyscarney merged commit 5d3547a into ROU-11568_V2 Feb 27, 2025
48 checks passed
@brandyscarney brandyscarney deleted the ROU-11568_V3 branch February 27, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thetaPC thetaPC thetaPC approved these changes

@BenOsodrac BenOsodrac BenOsodrac approved these changes

Assignees

No one assigned

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brandyscarney @thetaPC @BenOsodrac