Skip to content

fix(alert): change focused element and improve keyboard navigation #30220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 6, 2025
Merged

fix(alert): change focused element and improve keyboard navigation #30220

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
123514e
fix(ion-alert): fix a11y focus and keyboard navigation.
joselrio Feb 27, 2025
1c22eeb
fix(ion-alert): update testing screenshots
joselrio Feb 27, 2025
14879e5
fix(ion-alert): fix test validation
joselrio Feb 27, 2025
1909e03
fix(ion-alert): run lint
joselrio Feb 27, 2025
4d522b9
fix(alert): Add comment to give context about why this approach has b…
joselrio Mar 5, 2025
b87c481
fix(alert): run lint
joselrio Mar 5, 2025
1fb9f13
Update core/src/components/alert/alert.tsx
joselrio Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/src/components/alert/alert.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,9 +413,13 @@ export class Alert implements ComponentInterface, OverlayInterface {
await this.delegateController.attachViewToDom();

await present(this, 'alertEnter', iosEnterAnimation, mdEnterAnimation).then(() => {
/**
* Check if alert has only one button and no inputs.
* If so, focus the button, oderwise focus the alert wrapper.
* This will map to the default native alert behavior.
*/
if (this.buttons.length === 1 && this.inputs.length === 0) {
const queryBtn = this.wrapperEl?.querySelector('.alert-button') as HTMLButtonElement;

queryBtn.focus();
} else {
this.wrapperEl?.focus();
Expand Down
Loading