-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(radio-group): add helperText and errorText properties #30222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 21 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
0827a4c
feat(radio-group): add helperText and errorText properties
brandyscarney a8d5165
test(radio-group): add e2e test for supporting text
brandyscarney b945277
chore(): add updated snapshots
brandyscarney c1ac2bf
chore: build
brandyscarney f20d8ed
fix(radio-group): use inline block to avoid taking up entire width
brandyscarney fbf4f84
chore(): add updated snapshots
brandyscarney e3795e3
fix(radio-group): remove display
brandyscarney 5c23457
chore(): add updated snapshots
brandyscarney ef31de3
fix(radio-group): fix firefox alignment
brandyscarney b9d8cb9
fix(angular): mark radio group as touched when radio is blurred
brandyscarney d71d7f4
style: lint
brandyscarney 15c8a69
fix(radio-group): wrap slot in a div to resolve blurring on focus
brandyscarney 5edfdcf
refactor(radio-group): change supporting-text class to radio-group-top
brandyscarney 22d59cf
style: code comments
brandyscarney 1e925ba
fix(radio-group): use proper classes and colors
brandyscarney 5c8a1ab
test(radio-group): fix custom css
brandyscarney 33417fe
chore(): add updated snapshots
brandyscarney 55e1c29
fix(radio-group): use inline div to avoid extra spacing
brandyscarney 051c74b
test(radio): update css to max 3 per row but wrap
brandyscarney 11f607a
style: comment
brandyscarney c222328
Merge branch 'feature-8.5' into ROU-11554
brandyscarney eb42793
test(radio-group): update e2e test to verify correct element
brandyscarney d4230a0
Merge branch 'feature-8.5' into ROU-11554
brandyscarney a53ee64
style: add FW issue for tracking Stencil issue
brandyscarney cb10db6
fix(angular): add missing props
brandyscarney 69db209
Merge branch 'feature-8.5' into ROU-11554
brandyscarney 6a5f2f7
Merge branch 'feature-8.5' into ROU-11554
brandyscarney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| @import "../../themes/ionic.globals.ios"; | ||
| @import "./radio-group"; | ||
| @import "../item/item.ios.vars"; | ||
|
|
||
| // iOS Radio Group Top in List | ||
| // -------------------------------------------------- | ||
|
|
||
| // Add padding to the error and helper text when used in a | ||
| // list to align them with the list header and item text. | ||
| ion-list .radio-group-top { | ||
| @include padding-horizontal($item-ios-padding-start, $item-ios-padding-end); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| @import "../../themes/ionic.globals.md"; | ||
| @import "./radio-group"; | ||
| @import "../item/item.md.vars"; | ||
|
|
||
| // Material Design Radio Group Top in List | ||
| // -------------------------------------------------- | ||
|
|
||
| // Add padding to the error and helper text when used in a | ||
| // list to align them with the list header and item text. | ||
| ion-list .radio-group-top { | ||
| @include padding-horizontal($item-md-padding-start, $item-md-padding-end); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| @import "../../themes/ionic.globals"; | ||
|
|
||
| // Radio Group | ||
| // -------------------------------------------------- | ||
|
|
||
| ion-radio-group { | ||
| // Prevents additional pixels from being rendered on top | ||
| vertical-align: top; | ||
| } | ||
|
|
||
| .radio-group-wrapper { | ||
| display: inline; | ||
| } | ||
|
|
||
| // Radio Group: Top | ||
| // -------------------------------------------------- | ||
|
|
||
| .radio-group-top { | ||
| line-height: 1.5; | ||
| } | ||
|
|
||
| /** | ||
| * Error text should only be shown when .ion-invalid is present | ||
| * on the radio group. Otherwise the helper text should be shown. | ||
| */ | ||
| .radio-group-top .error-text { | ||
| display: none; | ||
|
|
||
| color: ion-color(danger, base); | ||
| } | ||
|
|
||
| .radio-group-top .helper-text { | ||
| display: block; | ||
|
|
||
| color: $text-color-step-300; | ||
| } | ||
|
|
||
| .ion-touched.ion-invalid .radio-group-top .error-text { | ||
| display: block; | ||
| } | ||
|
|
||
| .ion-touched.ion-invalid .radio-group-top .helper-text { | ||
| display: none; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.