Skip to content

Conversation

@christian-bromann
Copy link
Contributor

@christian-bromann christian-bromann commented Mar 17, 2025

Issue number: resolves #30254


What is the current behavior?

The type for routerLink was incorrectly set as symbol.

What is the new behavior?

The new update of the Vue output target to sets it to string | symbol

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 8.5.1-dev.11742238707.15ce0fe2

@christian-bromann christian-bromann requested a review from a team as a code owner March 17, 2025 07:14
@vercel
Copy link

vercel bot commented Mar 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 1:41pm

@github-actions github-actions bot added package: core @ionic/core package package: vue @ionic/vue package labels Mar 17, 2025
@brandyscarney brandyscarney changed the title chore(vue): update output target to v0.10.6 fix(vue): update output target and fix incorrect types Mar 17, 2025
@brandyscarney brandyscarney self-requested a review March 17, 2025 18:53
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed in my testing that the latest dev build resolves the type errors and the user also confirmed it fixes their issue. Thank you! 🎉

@brandyscarney brandyscarney added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit f4186c6 Mar 18, 2025
51 checks passed
@brandyscarney brandyscarney deleted the cb/vue-ot-update branch March 18, 2025 14:52
brandyscarney added a commit that referenced this pull request Mar 19, 2025
Issue number: resolves #30254

---------

The type for `routerLink` was incorrectly set as `symbol`.

The new update of the Vue output target to sets it to `string | symbol`

- [ ] Yes
- [x] No

Dev build: `8.5.1-dev.11742238707.15ce0fe2`

---------

Co-authored-by: Brandy Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package package: vue @ionic/vue package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: (vue) router-link has wrong type since 8.4.5/8.5.0

3 participants