fix(input): remove z-index target-area for ionic theme #30261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
OS-martacarlos
force-pushed
the
ROU-11733
branch
from
b3b7466 to
353070f
Compare
OS-martacarlos
force-pushed
the
ROU-11733
branch
from
353070f to
b79c5be
Compare
OS-martacarlos
force-pushed
the
ROU-11733
branch
from
b79c5be to
57d8e77
Compare
- add tests screenshots
OS-martacarlos
force-pushed
the
ROU-11733
branch
from
57d8e77 to
1cad66b
Compare
thetaPC
requested changes
Mar 20, 2025
| // Cursor should match the native input when hovering over the target area. | ||
| cursor: text; | ||
|
|
||
| z-index: 1; |
Contributor
There was a problem hiding this comment.
Did we ever figure out why this was added in the first place?
Author
There was a problem hiding this comment.
No, it's still a question with no answer
Contributor
There was a problem hiding this comment.
We'll just have to keep this in mind if we run into issues later. Have we verified if textarea is behaving correctly? It follows the same structure as input that it might also lead to the same issue.
Author
There was a problem hiding this comment.
I've done a simple / quick test on the textarea and haven't found any issue so far
Co-authored-by: Maria Hutt <[email protected]>
thetaPC
changed the title
BenOsodrac
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Currently, operations associated with gestures aren’t working, for the ionic theme:
What is the new behavior?
Does this introduce a breaking change?
Notes
Currently, the double click text selection is not working (the text isn't selected) on the automated tests for:
as manual tests do not have this problem, we'll be skipping these tests for now and come back to them at a later date