feat(divider): add new ion-divider component #30270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: angular
OS-martacarlos
force-pushed
the
ROU-11632
branch
from
8595c9b to
e51076c
Compare
OS-martacarlos
force-pushed
the
ROU-11632
branch
from
e51076c to
0bdf960
Compare
OS-martacarlos
force-pushed
the
ROU-11632
branch
from
0bdf960 to
3a7dc3e
Compare
brandyscarney
requested changes
Mar 20, 2025
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Looking good so far, just found a few concerns. 🙂
Co-authored-by: Brandy Smith <[email protected]>
- apply more code review suggetions
OS-martacarlos
force-pushed
the
ROU-11632
branch
from
6126970 to
f2a9b59
Compare
Member
There was a problem hiding this comment.
Thank you for making those changes! The only blocking change I'm requesting is that I noticed the safe area padding for LTR/RTL is missing on one side because I copied the styles from item. Sorry I just realized this! The rest of my requests are just to limit the number of screenshots generated by the E2E tests to only what we really need. 🙂
...ic/divider.e2e.ts-snapshots/divider-basic-default-ionic-md-rtl-light-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
...ng/divider.e2e.ts-snapshots/divider-spacing-large-ionic-md-rtl-light-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
Co-authored-by: Brandy Smith <[email protected]>
OS-martacarlos
force-pushed
the
ROU-11632
branch
from
6dd88fe to
b7bd3e3
Compare
thetaPC
requested changes
Mar 24, 2025
Co-authored-by: Maria Hutt <[email protected]>
Co-authored-by: Maria Hutt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the new behavior?
ion-dividerwhich has two props,spacingandinset.spacingandinsetpropsDoes this introduce a breaking change?
Other information
ion-itemis out of scope , for now.