fix(input): remove css variable and update helper text to use valid highlight in ionic theme #30272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
changed the title
brandyscarney
commented
Mar 20, 2025
| } | ||
|
|
||
| :host(.ion-touched.ion-invalid) .error-text { | ||
| color: var(--text-color-invalid); |
Member
Author
There was a problem hiding this comment.
This code can be removed because the common file has this:
.input-bottom .error-text {
color: var(--highlight-color-invalid);
}
brandyscarney
changed the title
brandyscarney
commented
Mar 20, 2025
Member
Author
There was a problem hiding this comment.
This is expected because I removed the 5px padding top from the helper/error text which is not in the Figma design
brandyscarney
commented
Mar 20, 2025
Member
Author
There was a problem hiding this comment.
This is expected because I removed the 5px padding top from the helper/error text which is not in the Figma design
brandyscarney
commented
Mar 20, 2025
Member
Author
There was a problem hiding this comment.
I updated the helper text to use the --highlight-color-valid which follows how customizing the invalid color works.
brandyscarney
changed the title
BenOsodrac
approved these changes
Mar 21, 2025
brandyscarney
commented
Mar 21, 2025
BenOsodrac
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the new behavior?
--text-color-invalidvariable so the customization across components and themes for helper & error text is consistent.--highlight-color-validto ensure customization works the same as invalidDoes this introduce a breaking change?
This theme is not released yet so it is not a breaking change to remove CSS variables.
Other information
Preview