feat(avatar): add disabled property #30284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update snapshots;
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: angular
JoaoFerreira-FrontEnd
requested review from
ShaneK
and removed request for
ShaneK
- update shape tests; - update snapshots;
brandyscarney
requested changes
Mar 21, 2025
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Looks good just a few requested changes!
brandyscarney
changed the title
ShaneK
reviewed
Mar 21, 2025
- use mixin disable-state on before pseudo-element; - improve render; - remove snapshots tests from basic page scope; - remove snapshots tests from shapes page scope; - remove snapshots; - create folder for states tests; - create page and tests for states (disabled);
Co-authored-by: Brandy Smith <[email protected]>
Co-authored-by: Brandy Smith <[email protected]>
ShaneK
approved these changes
Mar 21, 2025
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Looks good to me! I do agree with Brandy's comment though, mostly because if it doesn't get cleaned up now it'll probably never be and may end up being copied/pasted around. But it's pretty minor, so 🤷
Co-authored-by: Brandy Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Avatar does not have a disabled state for the ionic theme.
What is the new behavior?
Does this introduce a breaking change?
Other information
Preview