-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(checkbox): ensure proper visual selection when navigating via VoiceOver in Safari #30300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+27
−3
Merged
Changes from 5 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
04174da
fix(checkbox): fix safari voice over not recognizing ion-checkbox as …
ShaneK d82a204
fix(checkbox): fixing accessibility issues created by making host ele…
ShaneK dbc7d7a
fix(checkbox): trying to fix lack of label error
ShaneK e7a70de
chore(checkbox): moving comment out of render so it doesn't end up in…
ShaneK 3feceb4
fix(checkbox): lint
ShaneK 247f6d6
fix(checkbox): remove focusable on disabled
ShaneK 9fabf82
refactor(checkbox): targetting checkbox through instead of new class
ShaneK e8446ca
Update core/src/components/checkbox/checkbox.scss
ShaneK 007391b
Update core/src/components/checkbox/checkbox.tsx
ShaneK bbeff5b
Update core/src/components/checkbox/checkbox.tsx
ShaneK 7434c73
Update core/src/components/checkbox/checkbox.tsx
ShaneK 1646e1e
Update core/src/components/checkbox/checkbox.scss
ShaneK 6a35a26
Update core/src/components/checkbox/checkbox.tsx
ShaneK d674ad1
Update core/src/components/checkbox/checkbox.tsx
ShaneK 875cc38
Merge branch 'main' of github.com:ionic-team/ionic-framework into FW-…
ShaneK 24c1c18
refactor(checkbox): move label ID to class property
ShaneK 678d747
refactor(label): test removing fallback checkbox label
ShaneK f0cd91b
refactor(checkbox): code clean up
ShaneK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.