-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(chip): add hue property for the ionic theme #30308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
9b25ed0
feat(css): add support for the subtle color map
brandyscarney 2a0fdf3
Merge branch 'next' into FW-6252
brandyscarney e8605e7
test(theme): skip test because all tests fail on one or more colors
brandyscarney 5391165
chore(): add updated snapshots
Ionitron 19c944a
style: comments
brandyscarney 5d79e3c
feat(chip): add subtle hue for the ionic theme
brandyscarney 8a94fd4
chore: build
brandyscarney 147550a
Merge branch 'next' into FW-6252
brandyscarney e13d85d
Merge branch 'next' into FW-6252
brandyscarney 8fc775f
refactor(themes): add foreground color for colors when used as text
brandyscarney 9bfe374
test(theme): use proper color variants
brandyscarney caf3c2d
style: lint
brandyscarney aed941f
test(themes): re-enable tests with correct checks
brandyscarney e86e9d5
chore(): add updated snapshots
Ionitron 59d713f
revert back to tokens
brandyscarney 6306fe6
style: lint
brandyscarney 5811fbd
Merge branch 'FW-6252' into FW-6252-chip
brandyscarney a84f282
Merge branch 'next' into FW-6252
brandyscarney 60a241f
fix(themes): add tertiary, remove TODOs
brandyscarney d5a79c5
Merge branch 'FW-6252' into FW-6252-chip
brandyscarney 465a5ef
lint again and again and again
brandyscarney ed28ff0
Merge branch 'FW-6252' into FW-6252-chip
brandyscarney feb8cf6
chore(): add updated snapshots
Ionitron 3187866
chore(): add updated snapshots
Ionitron 75421d3
fix(themes): update other palettes to include foreground
brandyscarney eca3566
fix(themes): do not require the foreground variant for ios and md
brandyscarney 67f8334
Merge branch 'next' into FW-6252
brandyscarney e62292f
Merge branch 'FW-6252' into FW-6252-chip
brandyscarney 22ddb4c
fix(css): remove the unused foreground vars
brandyscarney 6d05513
style: comment cleanup
brandyscarney da4e069
fix(themes): fallback to base if foreground is undefined
brandyscarney 7ec8f9d
test(chip): add hue test for ionic theme
brandyscarney 3fd42cb
Merge branch 'FW-6252' into FW-6252-chip
brandyscarney 1cd9598
refactor(chip): only apply the color / background to hue classes
brandyscarney d737ccc
docs
brandyscarney fd300b2
style: add in jira ticket
brandyscarney 3e8037c
Merge branch 'next' into FW-6252-chip
brandyscarney d50eec1
Merge branch 'next' into FW-6252-chip
brandyscarney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| @import "../../themes/mixins"; | ||
|
|
||
| // Chip: Common Styles | ||
| // -------------------------------------------------- | ||
|
|
||
| :host { | ||
| /** | ||
| * @prop --background: Background of the chip | ||
| * @prop --color: Color of the chip | ||
| * @prop --border-radius: Border radius of the chip | ||
| */ | ||
| @include font-smoothing(); | ||
|
|
||
| display: inline-flex; | ||
|
|
||
| position: relative; | ||
|
|
||
| align-items: center; | ||
| justify-content: center; | ||
|
|
||
| background: var(--background); | ||
| color: var(--color); | ||
|
|
||
| cursor: pointer; | ||
|
|
||
| overflow: hidden; | ||
|
|
||
| box-sizing: border-box; | ||
|
|
||
| vertical-align: middle; | ||
| } | ||
|
|
||
| :host(.chip-disabled) { | ||
| cursor: default; | ||
| pointer-events: none; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| @import "./chip"; | ||
| @import "./chip.native"; | ||
| @import "./chip.vars"; | ||
|
|
||
| :host { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| @import "./chip"; | ||
| @import "./chip.native"; | ||
| @import "./chip.vars"; | ||
|
|
||
| :host { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-205 Bytes
(94%)
....e2e.ts-snapshots/chip-outline-color-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-40 Bytes
(99%)
...e2e.ts-snapshots/chip-outline-color-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-10 Bytes
(100%)
....e2e.ts-snapshots/chip-outline-color-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+192 Bytes
(120%)
...c/chip.e2e.ts-snapshots/chip-outline-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-117 Bytes
(96%)
...ip.e2e.ts-snapshots/chip-solid-color-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-23 Bytes
(99%)
...p.e2e.ts-snapshots/chip-solid-color-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+30 Bytes
(100%)
...ip.e2e.ts-snapshots/chip-solid-color-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.